Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: posterior API's #2953

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

koolgax99
Copy link
Contributor

Description

Here we extend the PEcAn API's by adding Posterior file API's. Currently, we only have 2 API's

  • /api/posteriors/ which lists all the posterior files
  • /api/posteriors/{posterior_id}/ which allows users to download the desired posterior file.

More information about these API's can be viewed in the Swagger documentation.

Tests are yet to be added for this API. The second API is still in progress and needs suggestions from various contributors

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@koolgax99
Copy link
Contributor Author

@mdietze sir can you have a look at the API?

@robkooper
Copy link
Member

what is left with the PR?

@koolgax99
Copy link
Contributor Author

what is left with the PR?

Sir the tests are to be added in the PR

@infotroph infotroph marked this pull request as draft January 10, 2023 19:05
@allgandalf
Copy link
Collaborator

nearly 2 years and no update 😱 , are we getting this PR done or should we just close this @koolgax99 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants