-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default show_crop_map_links: false #678
base: develop
Are you sure you want to change the base?
Conversation
in defaults.yml 1. this should be off by default; they were only relevant to BETYdb.org 2. Google has deprecated Fusiontables that these maps use; easiest fix is not to show them. No longer a priority mandated by EBI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we want to keep this functionality on the EBI site for now, we'll have to override this default there when we update BETYdb there.
The maps no longer work on google fusion tables |
@dlebauer You seem to be right, although I thought Fusion Tables weren't going away until December 3. In any case, if we no longer want the maps, a cleaner solution would be to simply remove all the code associated with them rather than simply changing the default. |
@dlebauer do you want to update this to remove the maps all together? |
yep - we should remove the maps all together - google fusion tables and associated maps have been deprecated |
in defaults.yml