Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default show_crop_map_links: false #678

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

dlebauer
Copy link
Member

in defaults.yml

  1. this should be off by default; they were only relevant to BETYdb.org
  2. Google has deprecated Fusiontables that these maps use; easiest fix is not to show them. No longer a priority mandated by EBI

in defaults.yml

1. this should be off by default; they were only relevant to BETYdb.org
2. Google has deprecated Fusiontables that these maps use; easiest fix is not to show them. No longer a priority mandated by EBI
Copy link
Contributor

@gsrohde gsrohde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we want to keep this functionality on the EBI site for now, we'll have to override this default there when we update BETYdb there.

@dlebauer
Copy link
Member Author

The maps no longer work on google fusion tables

@gsrohde
Copy link
Contributor

gsrohde commented Sep 17, 2019

@dlebauer You seem to be right, although I thought Fusion Tables weren't going away until December 3.

In any case, if we no longer want the maps, a cleaner solution would be to simply remove all the code associated with them rather than simply changing the default.

@robkooper
Copy link
Member

@dlebauer do you want to update this to remove the maps all together?

@dlebauer
Copy link
Member Author

dlebauer commented Apr 2, 2020

yep - we should remove the maps all together - google fusion tables and associated maps have been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants