-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding features like serviceAccountName for OpenShift security constraints #8
Open
computate
wants to merge
2
commits into
PecanProject:main
Choose a base branch
from
computate-org:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robkooper
requested changes
Mar 3, 2023
computate
force-pushed
the
main
branch
2 times, most recently
from
March 23, 2023 21:38
c089549
to
fd53e62
Compare
@robkooper I noticed I didn't have a value for serviceAccount:
# Specifies whether a service account should be added to the deployment
enabled: false
# Specifies whether a service account should be created
create: false
# Annotations to add to the service account
annotations: {}
# The name of the service account to use.
# If not set and create is true, a name is generated using the fullname template
name: "" |
computate
force-pushed
the
main
branch
2 times, most recently
from
April 5, 2023 14:36
1c9995e
to
c47f4a6
Compare
…aints - Fix a bug with postgresql.enabled value - Add optional serviceAccount to deployment for required security on OpenShift - Add docs for the new serviceAccount values - Allow customizing the postgresqlDatabase value and PGDATABASE environment variable on the betydb container - Allow disabling the creation of a betydb Secret in order to use an ExternalSecret from a vault instead - Remove the conflicting PGDATABASE in the init container that points to the bety database - Removing the PG_TABLE=sessions and PG_DATABASE=bety environment variable - When the PG_TABLE=sessions environment variable is set, the check-postgresql init container fails. When the deployment fails, the argocd application never completes and enters the post-install phase. The load-db Job depends on the post-install hook running, so the bety database is never created. - Remove post-install helm hook from load-db Job so that the bety database gets created for the Deployment - Added string around the -r 0 parameter of the command parent 9cc5541 author Christopher Tate <[email protected]> 1677561053 -0700 committer Christopher Tate <[email protected]> 1680705101 -0600 gpgsig -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEE8gjca+F8TU1M4A3jZbVOLA7tOVIFAmQthk0ACgkQZbVOLA7t OVIK1AgA1wYe2xmMRpyz/qQfGH7UpdoLv+az9JReXlW2+cda41VYaQahcEUSuRy3 c3iJynk5uoaO9QcR8gKGThmuO6kZYpJceyaPGP/ms+KBT+rgN9XFcUPQIGjuRIoj OplUx9IqKPrTqVLb7H448QHNDq+oST43vvmzxmXei5KSHSxq6Vrjgiqe+3UoyjdM HidKEaIYddajhpbzGiHZ96klIq5TNiU+q1xsuTzT5fsFkiPzwrpom5H5MlQ31EGg CeKpBPtG7qNI3zrK3gi9//4n8BlYqh14ncr/7Ju5MxP9bjIHyL22ksasMYL3HMxu ggwyLGRQmhbpsXoRHVbxelyi381a7w== =pmxl -----END PGP SIGNATURE-----
robkooper
approved these changes
May 21, 2024
Let me update my pr for postgres to update the documentation as pointed out by @infotroph and I can merge both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent 9cc5541
author Christopher Tate [email protected] 1677561053 -0700 committer Christopher Tate [email protected] 1677684028 -0700