Fix an "implicitly-declared copy assignment operator" warning #693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered with -Wextra (-Wdeprecated-copy).
Addresses part of #660.
I think I've done this correctly, but please triple-check my changes. (@luni64 I'd love your opinion here too.) I believe the behaviour changes because, when it uses the implicitly-declared copy assignment operator,
copy_tcd()
isn't called, but with my changes, it is called.It's this function that's complaining: