Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing skill gems from 3.24 patch notes #7404

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Update existing skill gems from 3.24 patch notes #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
130db23
Update skills M-Z for Necropolis 3.24
Wires77 Mar 23, 2024
479781d
Add Spectral Throw of Materialising
Wires77 Mar 23, 2024
dfbbf4d
Remaining Summon Skills + A -M
Mar 23, 2024
3a8afed
Archmage Support
Mar 23, 2024
8395ca3
Fix ModCache
Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Data/Minions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ minions["RaisedSkeletonArcher"] = {
coldResist = 40,
lightningResist = 40,
chaosResist = 20,
damage = 0.98,
damage = 1.13,
damageSpread = 0.16,
attackTime = 1.33,
attackRange = 40,
Expand Down
34 changes: 21 additions & 13 deletions src/Data/ModCache.lua
View file
Open in desktop

Large diffs are not rendered by default.

877 changes: 480 additions & 397 deletions src/Data/Skills/act_dex.lua
View file
Open in desktop

Large diffs are not rendered by default.

768 changes: 382 additions & 386 deletions src/Data/Skills/act_int.lua
View file
Open in desktop

Large diffs are not rendered by default.

184 changes: 92 additions & 92 deletions src/Data/Skills/act_str.lua
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 7 additions & 11 deletions src/Data/Skills/minion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ skills["SandstormChaosElementalSummonedEmpowered"] = {
"sandstorm_applies_withered_to_enemies_within",
},
levels = {
[1] = { 16.666667039196, storedUses = 1, levelRequirement = 3, cooldown = 8, statInterpolation = { 3, }, },
[1] = { 21.666667039196, storedUses = 1, levelRequirement = 3, cooldown = 8, statInterpolation = { 3, }, },
},
}
skills["FireElementalFlameRedSummoned"] = {
Expand Down Expand Up @@ -232,7 +232,7 @@ skills["FireElementalMeteorSummoned"] = {
"is_area_damage",
},
levels = {
[1] = { 16.666667039196, damageEffectiveness = 3.5, baseMultiplier = 3.5, levelRequirement = 1, statInterpolation = { 3, }, },
[1] = { 21.666667039196, damageEffectiveness = 5.25, baseMultiplier = 5.25, levelRequirement = 1, statInterpolation = { 3, }, },
},
}
skills["IceElementalIceCyclone"] = {
Expand Down Expand Up @@ -309,7 +309,7 @@ skills["IceElementalSpearSummonedDeathNova"] = {
name = "Death Nova",
hidden = true,
color = 3,
baseEffectiveness = 4.5626001358032,
baseEffectiveness = 5.7825001358032,
incrementalEffectiveness = 0.034600000828505,
skillTypes = { [SkillType.Projectile] = true, [SkillType.ProjectilesFromUser] = true, [SkillType.Spell] = true, [SkillType.Trappable] = true, [SkillType.Totemable] = true, [SkillType.Triggerable] = true, },
statDescriptionScope = "skill_stat_descriptions",
Expand All @@ -321,7 +321,7 @@ skills["IceElementalSpearSummonedDeathNova"] = {
},
constantStats = {
{ "monster_reverse_point_blank_damage_-%_at_minimum_range", 25 },
{ "number_of_additional_projectiles", 11 },
{ "number_of_additional_projectiles", 13 },
},
stats = {
"spell_minimum_base_cold_damage",
Expand Down Expand Up @@ -1900,7 +1900,7 @@ skills["ElementalHitCloneShot"] = {
"skill_can_fire_wand_projectiles",
},
levels = {
[1] = { damageEffectiveness = 5.5, baseMultiplier = 5.5, levelRequirement = 0, },
[1] = { damageEffectiveness = 6.875, baseMultiplier = 6.875, levelRequirement = 0, },
},
}
skills["SumonRagingSpiritMelee"] = {
Expand All @@ -1916,13 +1916,9 @@ skills["SumonRagingSpiritMelee"] = {
melee = true,
},
stats = {
"active_skill_damage_+%_final",
},
levels = {
[1] = { 0, levelRequirement = 1, statInterpolation = { 2, }, },
[2] = { 0, levelRequirement = 4, statInterpolation = { 2, }, },
[3] = { 1, levelRequirement = 5, statInterpolation = { 2, }, },
[4] = { 45, levelRequirement = 84, statInterpolation = { 2, }, },
[1] = { levelRequirement = 0, },
},
}
skills["AnimateGuardianSmite"] = {
Expand Down Expand Up @@ -1963,6 +1959,6 @@ skills["AnimateGuardianSmite"] = {
"visual_hit_effect_elemental_is_holy",
},
levels = {
[1] = { damageEffectiveness = 2.5, baseMultiplier = 2.5, levelRequirement = 1, },
[1] = { damageEffectiveness = 3.25, baseMultiplier = 3.25, levelRequirement = 1, },
},
}
95 changes: 47 additions & 48 deletions src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,80 +301,79 @@ skills["SupportArcaneSurge"] = {
}
skills["SupportArchmage"] = {
name = "Archmage",
description = "Supports spell skills that deal damage with hits and have no reservation. Cannot support arcane skills, Vaal skills, or skills used by totems, traps or mines. Cannot modify the skills of minions.",
description = "Supports spell skills that deal damage with hits and have no reservation. Cannot support brand skills, orb skills, arcane skills, Vaal skills, or skills used by totems, traps or mines. Cannot modify the skills of minions.",
color = 3,
baseEffectiveness = 0.17499999701977,
incrementalEffectiveness = 0.039000000804663,
support = true,
requireSkillTypes = { SkillType.Damage, SkillType.Spell, SkillType.AND, },
addSkillTypes = { },
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.Trapped, SkillType.RemoteMined, SkillType.HasReservation, SkillType.Vaal, SkillType.Arcane, },
excludeSkillTypes = { SkillType.SummonsTotem, SkillType.Trapped, SkillType.RemoteMined, SkillType.HasReservation, SkillType.Vaal, SkillType.Arcane, SkillType.Orb, SkillType.Brand, },
ignoreMinionTypes = true,
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["manaweave_cost_equals_%_unreserved_mana"] = {
skill("baseManaCostIsAtLeastPercentUnreservedMana", nil),
mod("ManaCost", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
},
["manaweave_added_lightning_damage_%_cost_if_payable"] = {
mod("LightningMin", "BASE", nil, 0, 0, { type = "PerStat", stat = "ManaCost" }),
mod("LightningMax", "BASE", nil, 0, 0, { type = "PerStat", stat = "ManaCost" }),
div = 100,
mod("LightningMin", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
mod("LightningMax", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
},
},
qualityStats = {
Default = {
{ "base_mana_cost_-%", -0.5 },
{ "spell_damage_+%", 0.5 },
},
},
constantStats = {
{ "manaweave_cost_equals_%_unreserved_mana", 5 },
{ "manaweave_added_lightning_damage_%_cost_if_payable", 75 },
},
stats = {
"global_minimum_added_lightning_damage",
"global_maximum_added_lightning_damage",
"manaweave_added_lightning_damage_%_cost_if_payable",
},
levels = {
[1] = { 0.10000000149012, 1.8999999761581, levelRequirement = 31, statInterpolation = { 3, 3, }, },
[2] = { 0.10000000149012, 1.8999999761581, levelRequirement = 34, statInterpolation = { 3, 3, }, },
[3] = { 0.10000000149012, 1.8999999761581, levelRequirement = 36, statInterpolation = { 3, 3, }, },
[4] = { 0.10000000149012, 1.8999999761581, levelRequirement = 38, statInterpolation = { 3, 3, }, },
[5] = { 0.10000000149012, 1.8999999761581, levelRequirement = 40, statInterpolation = { 3, 3, }, },
[6] = { 0.10000000149012, 1.8999999761581, levelRequirement = 42, statInterpolation = { 3, 3, }, },
[7] = { 0.10000000149012, 1.8999999761581, levelRequirement = 44, statInterpolation = { 3, 3, }, },
[8] = { 0.10000000149012, 1.8999999761581, levelRequirement = 46, statInterpolation = { 3, 3, }, },
[9] = { 0.10000000149012, 1.8999999761581, levelRequirement = 48, statInterpolation = { 3, 3, }, },
[10] = { 0.10000000149012, 1.8999999761581, levelRequirement = 50, statInterpolation = { 3, 3, }, },
[11] = { 0.10000000149012, 1.8999999761581, levelRequirement = 52, statInterpolation = { 3, 3, }, },
[12] = { 0.10000000149012, 1.8999999761581, levelRequirement = 54, statInterpolation = { 3, 3, }, },
[13] = { 0.10000000149012, 1.8999999761581, levelRequirement = 56, statInterpolation = { 3, 3, }, },
[14] = { 0.10000000149012, 1.8999999761581, levelRequirement = 58, statInterpolation = { 3, 3, }, },
[15] = { 0.10000000149012, 1.8999999761581, levelRequirement = 60, statInterpolation = { 3, 3, }, },
[16] = { 0.10000000149012, 1.8999999761581, levelRequirement = 62, statInterpolation = { 3, 3, }, },
[17] = { 0.10000000149012, 1.8999999761581, levelRequirement = 64, statInterpolation = { 3, 3, }, },
[18] = { 0.10000000149012, 1.8999999761581, levelRequirement = 66, statInterpolation = { 3, 3, }, },
[19] = { 0.10000000149012, 1.8999999761581, levelRequirement = 68, statInterpolation = { 3, 3, }, },
[20] = { 0.10000000149012, 1.8999999761581, levelRequirement = 70, statInterpolation = { 3, 3, }, },
[21] = { 0.10000000149012, 1.8999999761581, levelRequirement = 72, statInterpolation = { 3, 3, }, },
[22] = { 0.10000000149012, 1.8999999761581, levelRequirement = 74, statInterpolation = { 3, 3, }, },
[23] = { 0.10000000149012, 1.8999999761581, levelRequirement = 76, statInterpolation = { 3, 3, }, },
[24] = { 0.10000000149012, 1.8999999761581, levelRequirement = 78, statInterpolation = { 3, 3, }, },
[25] = { 0.10000000149012, 1.8999999761581, levelRequirement = 80, statInterpolation = { 3, 3, }, },
[26] = { 0.10000000149012, 1.8999999761581, levelRequirement = 82, statInterpolation = { 3, 3, }, },
[27] = { 0.10000000149012, 1.8999999761581, levelRequirement = 84, statInterpolation = { 3, 3, }, },
[28] = { 0.10000000149012, 1.8999999761581, levelRequirement = 86, statInterpolation = { 3, 3, }, },
[29] = { 0.10000000149012, 1.8999999761581, levelRequirement = 88, statInterpolation = { 3, 3, }, },
[30] = { 0.10000000149012, 1.8999999761581, levelRequirement = 90, statInterpolation = { 3, 3, }, },
[31] = { 0.10000000149012, 1.8999999761581, levelRequirement = 91, statInterpolation = { 3, 3, }, },
[32] = { 0.10000000149012, 1.8999999761581, levelRequirement = 92, statInterpolation = { 3, 3, }, },
[33] = { 0.10000000149012, 1.8999999761581, levelRequirement = 93, statInterpolation = { 3, 3, }, },
[34] = { 0.10000000149012, 1.8999999761581, levelRequirement = 94, statInterpolation = { 3, 3, }, },
[35] = { 0.10000000149012, 1.8999999761581, levelRequirement = 95, statInterpolation = { 3, 3, }, },
[36] = { 0.10000000149012, 1.8999999761581, levelRequirement = 96, statInterpolation = { 3, 3, }, },
[37] = { 0.10000000149012, 1.8999999761581, levelRequirement = 97, statInterpolation = { 3, 3, }, },
[38] = { 0.10000000149012, 1.8999999761581, levelRequirement = 98, statInterpolation = { 3, 3, }, },
[39] = { 0.10000000149012, 1.8999999761581, levelRequirement = 99, statInterpolation = { 3, 3, }, },
[40] = { 0.10000000149012, 1.8999999761581, levelRequirement = 100, statInterpolation = { 3, 3, }, },
[1] = { 0.10000000149012, 1.8999999761581, 10, levelRequirement = 31, statInterpolation = { 3, 3, }, },
[2] = { 0.10000000149012, 1.8999999761581, 10, levelRequirement = 34, statInterpolation = { 3, 3, }, },
[3] = { 0.10000000149012, 1.8999999761581, 11, levelRequirement = 36, statInterpolation = { 3, 3, }, },
[4] = { 0.10000000149012, 1.8999999761581, 11, levelRequirement = 38, statInterpolation = { 3, 3, }, },
[5] = { 0.10000000149012, 1.8999999761581, 12, levelRequirement = 40, statInterpolation = { 3, 3, }, },
[6] = { 0.10000000149012, 1.8999999761581, 12, levelRequirement = 42, statInterpolation = { 3, 3, }, },
[7] = { 0.10000000149012, 1.8999999761581, 13, levelRequirement = 44, statInterpolation = { 3, 3, }, },
[8] = { 0.10000000149012, 1.8999999761581, 13, levelRequirement = 46, statInterpolation = { 3, 3, }, },
[9] = { 0.10000000149012, 1.8999999761581, 14, levelRequirement = 48, statInterpolation = { 3, 3, }, },
[10] = { 0.10000000149012, 1.8999999761581, 14, levelRequirement = 50, statInterpolation = { 3, 3, }, },
[11] = { 0.10000000149012, 1.8999999761581, 15, levelRequirement = 52, statInterpolation = { 3, 3, }, },
[12] = { 0.10000000149012, 1.8999999761581, 15, levelRequirement = 54, statInterpolation = { 3, 3, }, },
[13] = { 0.10000000149012, 1.8999999761581, 16, levelRequirement = 56, statInterpolation = { 3, 3, }, },
[14] = { 0.10000000149012, 1.8999999761581, 16, levelRequirement = 58, statInterpolation = { 3, 3, }, },
[15] = { 0.10000000149012, 1.8999999761581, 17, levelRequirement = 60, statInterpolation = { 3, 3, }, },
[16] = { 0.10000000149012, 1.8999999761581, 17, levelRequirement = 62, statInterpolation = { 3, 3, }, },
[17] = { 0.10000000149012, 1.8999999761581, 18, levelRequirement = 64, statInterpolation = { 3, 3, }, },
[18] = { 0.10000000149012, 1.8999999761581, 18, levelRequirement = 66, statInterpolation = { 3, 3, }, },
[19] = { 0.10000000149012, 1.8999999761581, 19, levelRequirement = 68, statInterpolation = { 3, 3, }, },
[20] = { 0.10000000149012, 1.8999999761581, 19, levelRequirement = 70, statInterpolation = { 3, 3, }, },
[21] = { 0.10000000149012, 1.8999999761581, 20, levelRequirement = 72, statInterpolation = { 3, 3, }, },
[22] = { 0.10000000149012, 1.8999999761581, 20, levelRequirement = 74, statInterpolation = { 3, 3, }, },
[23] = { 0.10000000149012, 1.8999999761581, 21, levelRequirement = 76, statInterpolation = { 3, 3, }, },
[24] = { 0.10000000149012, 1.8999999761581, 21, levelRequirement = 78, statInterpolation = { 3, 3, }, },
[25] = { 0.10000000149012, 1.8999999761581, 22, levelRequirement = 80, statInterpolation = { 3, 3, }, },
[26] = { 0.10000000149012, 1.8999999761581, 22, levelRequirement = 82, statInterpolation = { 3, 3, }, },
[27] = { 0.10000000149012, 1.8999999761581, 23, levelRequirement = 84, statInterpolation = { 3, 3, }, },
[28] = { 0.10000000149012, 1.8999999761581, 23, levelRequirement = 86, statInterpolation = { 3, 3, }, },
[29] = { 0.10000000149012, 1.8999999761581, 24, levelRequirement = 88, statInterpolation = { 3, 3, }, },
[30] = { 0.10000000149012, 1.8999999761581, 24, levelRequirement = 90, statInterpolation = { 3, 3, }, },
[31] = { 0.10000000149012, 1.8999999761581, 25, levelRequirement = 91, statInterpolation = { 3, 3, }, },
[32] = { 0.10000000149012, 1.8999999761581, 25, levelRequirement = 92, statInterpolation = { 3, 3, }, },
[33] = { 0.10000000149012, 1.8999999761581, 26, levelRequirement = 93, statInterpolation = { 3, 3, }, },
[34] = { 0.10000000149012, 1.8999999761581, 26, levelRequirement = 94, statInterpolation = { 3, 3, }, },
[35] = { 0.10000000149012, 1.8999999761581, 27, levelRequirement = 95, statInterpolation = { 3, 3, }, },
[36] = { 0.10000000149012, 1.8999999761581, 27, levelRequirement = 96, statInterpolation = { 3, 3, }, },
[37] = { 0.10000000149012, 1.8999999761581, 28, levelRequirement = 97, statInterpolation = { 3, 3, }, },
[38] = { 0.10000000149012, 1.8999999761581, 28, levelRequirement = 98, statInterpolation = { 3, 3, }, },
[39] = { 0.10000000149012, 1.8999999761581, 29, levelRequirement = 99, statInterpolation = { 3, 3, }, },
[40] = { 0.10000000149012, 1.8999999761581, 29, levelRequirement = 100, statInterpolation = { 3, 3, }, },
},
}
skills["SupportBlasphemy"] = {
Expand Down
2 changes: 1 addition & 1 deletion src/Data/StatDescriptions/gem_stat_descriptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11793,7 +11793,7 @@ return {
[2]="#"
}
},
text="Supported Skills have base Mana Cost equal to {0}% of Unreserved Maximum Mana, if that value is higher\nSupported Skills gain Added Lightning Damage equal to {1}% of Mana Cost, if Mana Cost is not higher than the maximum you could spend"
text="Supported Skills have added Mana Cost equal to {0}% of Unreserved Maximum Mana\nSupported Skills gain Added Lightning Damage equal to {1}% of Unreserved Maximum Mana"
},
[2]={
[1]={
Expand Down
5 changes: 5 additions & 0 deletions src/Export/Skills/act_dex.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2725,6 +2725,11 @@ local skills, mod, flag, skill = ...
#baseMod mod("PierceChance", "BASE", 100)
#mods

#skill ThrownWeaponAltX
#flags attack projectile
#baseMod mod("PierceChance", "BASE", 100)
#mods

#skill VaalThrownWeapon
#flags attack projectile vaal
statMap = {
Expand Down
4 changes: 0 additions & 4 deletions src/Export/Skills/act_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,10 +2098,6 @@ local skills, mod, flag, skill = ...
#skill KineticBoltAltX
#flags attack projectile
statMap = {
["active_skill_additive_spell_damage_modifiers_apply_to_attack_damage_at_%_value"] = {
flag("SpellDamageAppliesToAttacks"),
mod("ImprovedSpellDamageAppliesToAttacks", "MAX", nil),
},
["quality_display_spell_damage_to_attack_damage_is_gem"] = {
--Display Only
},
Expand Down
4 changes: 2 additions & 2 deletions src/Export/Skills/act_str.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,8 @@ local skills, mod, flag, skill = ...
flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff" }),
},
["chain_strike_cone_radius_+_per_x_rage"] = {
mod("AreaOfEffect", "BASE", nil, 0, 0, { type = "Multiplier", var = "Rage", div = 3 }),
div = 3,
mod("AreaOfEffect", "BASE", nil, 0, 0, { type = "Multiplier", var = "Rage", div = 5 }),
div = 5,
},
["quality_display_chain_hook_is_gem"] = {
-- Display only
Expand Down
7 changes: 3 additions & 4 deletions src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@ local skills, mod, flag, skill = ...
#skill SupportArchmage
statMap = {
["manaweave_cost_equals_%_unreserved_mana"] = {
skill("baseManaCostIsAtLeastPercentUnreservedMana", nil),
mod("ManaCost", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
},
["manaweave_added_lightning_damage_%_cost_if_payable"] = {
mod("LightningMin", "BASE", nil, 0, 0, { type = "PerStat", stat = "ManaCost" }),
mod("LightningMax", "BASE", nil, 0, 0, { type = "PerStat", stat = "ManaCost" }),
div = 100,
mod("LightningMin", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
mod("LightningMax", "BASE", nil, 0, 0, { type = "PercentStat", stat = "ManaUnreserved" , percent = 1 }),
},
},
#mods
Expand Down
3 changes: 0 additions & 3 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,9 +1547,6 @@ function calcs.offence(env, actor, activeSkill)
--Divine Blessing / Totem aura skills that have a percent reservation, round instead of floor the value. This corrects the final result if it would round up
divineBlessingCorrection = round((output[resource] or 0) * reservedPercent / 100 * mult) - m_floor((output[resource] or 0) * reservedPercent / 100 * mult)
end
if resource == "Mana" and skillData.baseManaCostIsAtLeastPercentUnreservedMana then -- Archmage
baseCost = m_max(baseCost, m_max(m_floor((output.ManaUnreserved or 0) * skillData.baseManaCostIsAtLeastPercentUnreservedMana / 100)), 1)
end
end
val.baseCost = val.baseCost + baseCost
val.baseCostNoMult = val.baseCostNoMult + baseCostNoMult
Expand Down
Loading