Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary usage of slotcfg for energy shield and ward calculations #7359

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 20, 2024

Fixes #7357

Description of the problem being solved:

The usage of slotcfg seems to have been carried forward initially being added in ae21519. For player calculations slotcfg will always be:

{
    slotName = "Weapon 2"
}

Due to it only ever being set int the loop above

for _, slot in pairs({"Helmet","Gloves","Boots","Body Armour","Weapon 2","Weapon 3"}) do

This seems incorrect for a global effect and causes the shield only effects to apply causing the mentioned issue.

@Paliak Paliak added the bug: calculation Numerical differences label Feb 21, 2024
@LocalIdentity LocalIdentity merged commit a1e2132 into PathOfBuildingCommunity:dev Mar 9, 2024
2 checks passed
@Paliak Paliak deleted the issue-7357 branch March 10, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Increased Energy Shield From Equipped Shield" causes incorrect breakdown for Total Energy Shield in Calcs Tab
2 participants