Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit updater out early if a file download fails #5613

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Jan 19, 2023

Exit updater out early if a file download fails, this is due to the update not applying anyway if a fail download fails

Other improvements that could be made are:

  1. checking the download folder for files downloaded incase a previous download failed or was canceled
    or 2) having it automatically clearing the download folder instead of leaving files there to be overridden

@QuickStick123 QuickStick123 added the technical Hidden from release notes label Jan 23, 2023
@Wires77
Copy link
Member

Wires77 commented Apr 6, 2023

I think having the other improvements in place would make this a better PR. There's nothing really wrong with this as-is, but the main issue is people entering a download loop in the first place due to shoddy internet, and the updater not using the files it could get to in time.

Then of course we wouldn't want to exit early, in case the first file fails, but the rest are all fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants