New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Phantasm DPS in Total DPS #4661

Open

APXEOLOG wants to merge 1 commit into PathOfBuildingCommunity:dev from APXEOLOG:feature/initial-phantasm-support-in-total-dps

Contributor

APXEOLOG commented Jul 28, 2022

Description of the problem being solved:

Phantasms are not being counted in the Total DPS even if the skill has this support gem inserted

Count is based on maximum available phantasm limit
DPS is always calculated for the "Physical Projectile" minion's skill
Such problem as multiple phantasm sources and global limit is out of scope

Steps taken to verify a working solution:

Create a new skill group
Add some active skill gem
Add Summon Phantasm
Toggle "Show in Total DPS"

Link to a build that showcases this PR:

https://pobb.in/HMjN6iKQ-EDg

Before screenshot:

After screenshot:


          Properly display Phantasm DPS in Total DPS

15fcbc8

QuickStick123 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels