Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death Wish (Maw of Mischief) rework #4241

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Feb 27, 2022

This adds a minion selector (currently only used by Death Wish), separates the spell and minion explosion components of Death Wish, add some new functionality to the config tab. There's also a bit of miscellaneous code clean up in here (formatting mostly).

Fixes #2372.

Link to a build that showcases this PR:

https://pobb.in/VcllNw4VS8tM

After screenshot:

.. separate the spell and minion explosion components of Death Wish, add some new functionality to the config tab, and other minor code clean up.
@Lothrik Lothrik marked this pull request as ready for review March 9, 2022 01:19
@Lothrik Lothrik marked this pull request as draft May 28, 2022 07:11
@Lothrik
Copy link
Contributor Author

Lothrik commented May 28, 2022

Converting this PR to draft, as after reviewing several usability issues came up that need to be addressed.

Two notable examples are:

  • The minion selector list does not update automatically when minions change (which isn't ideal but can be worked around), and can get stuck in an invalid state if only one minion is present in the build (which is very problematic as it will persist until you restart PoB).
  • Node tooltip DPS estimates don't display correctly if Death Wish Full DPS calculates before minion life is recalculated. Manipulating the order Full DPS processes skills (forcing Death Wish to run last) should fix this fairly easily.

Also: Death Wish should likely have Full DPS force enabled as it cannot currently calculate its DPS correctly without it, due to the reliance on minion life calculations from other skills.

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Death Wish (Maw of Mischief) Uses Player Life instead of Minion Life
2 participants