Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death wish now uses it's own config instead of corpse life #4167

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jurgyy
Copy link

@jurgyy jurgyy commented Feb 16, 2022

Fixes #2372

Description of the problem being solved:

Death Wish targets your minions. However in PoB it uses the Enemy Corpse Life field to determine it's damage. With this PR whenever you have Death Wish a Skill Option is added in the Configuration tab with a "Death wise: Minion Life" field. This is practically identical to the way Dark Pact configures it's damage.

Steps taken to verify a working solution:

  • Equip "Maw of Mischief" unique helmet
  • Select "Death Wish" as main skill
  • Select "Minion Explosion" as skillPart
  • Go to Configuration tab
  • increase the newly added "Minion Life" field.
  • Check if the skill's damage increases.

Link to a build that showcases this PR:

https://pastebin.com/ksuBneXA

Before screenshot:

image

After screenshot:

image

@orlp
Copy link
Contributor

orlp commented Feb 26, 2022

I think it would be even better if the skill had a minion selector option from your minions, and used that minion's life. That way minion life nodes on the tree would also correctly indicate their DPS increase instead of having to manually enter the new life value and comparing.

@jurgyy
Copy link
Author

jurgyy commented Feb 26, 2022

@orlp, yeah, I was looking into that, but since I'm new I don't know enough to implement that. If someone can point me in the right direction I would love to do it though!

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Death Wish (Maw of Mischief) Uses Player Life instead of Minion Life
3 participants