Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for 'targets they chain from' #1055

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Adding support for 'targets they chain from' #1055

wants to merge 3 commits into from

Conversation

uilman
Copy link
Contributor

@uilman uilman commented Jun 21, 2020

Noted I couldn't apply a check for whether it was capable of chaining or not. So if you link lightning arrow to chain, check the box, then remove chain, the node still appears to provide benefit.
image
image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jun 21, 2020
@uilman uilman marked this pull request as ready for review July 15, 2020 01:23
ppoelzl
ppoelzl requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer ChainedFromTarget instead of TargetChainedFrom. Also "Skill chained from another target?" should be "Skill chains to another target?". It's unfortunate that the toggle stays active, but it shouldn't prevent us from merging this PR.

@uilman
Copy link
Contributor Author

uilman commented Oct 26, 2020

Change made, but identified a separate bug with applying 'projectile' flag on the parser.

@ppoelzl ppoelzl added the wip Unfinished and commited for discussion label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppoelzl ppoelzl ppoelzl requested changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod wip Unfinished and commited for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uilman @ppoelzl @LocalIdentity