Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Implemented getHeight and setHeight on AbstractButtonWidget #191

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Implemented getHeight and setHeight on AbstractButtonWidget #191

merged 2 commits into from
Sep 25, 2020

Conversation

bs2kbs2k
Copy link
Contributor

protected int height;

public int getHeight() {
return this.height;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these just be Accessors?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@YTG1234
Copy link
Contributor

YTG1234 commented Sep 16, 2020

In the future, when Patchwork is complete, I want to be able to use some Forge things in my Fabric mods (aka make 🦆 interfaces please)

Copy link
Contributor

@YTG1234 YTG1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good

Copy link
Member

@TheGlitch76 TheGlitch76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 95% sure Mixin mangles accessors, so this is good how it is.
Thanks for contributing!

@TheGlitch76 TheGlitch76 merged commit 1c8fd2a into PatchworkMC:master Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants