Update eslint from 1.x to 2.6.0, lodash 4.7.0

.eslintrc.js

@@ -0,0 +1,133 @@
+module.exports = {
+    'root': true,
+    'parser': 'babel-eslint',
+
+    'env': {
+        'es6': true,
+        'amd': true,
+        'jest': true,
+        'node': true,
+        'jquery': true,
+        'browser': true,
+        'serviceworker': true,
+    },
+
+    'parserOptions': {
+        'ecmaVersion': 7,
+        'sourceType': 'module',
+        'ecmaFeatures': {
+            'objectLiteralDuplicateProperties': false
+        }
+    },
+
+    'globals': {
+        'analytics': true,
+        'init': true,
+        'ga': true
+    },
+
+    'rules': {
+        // enforce or disallow variable initializations at definition
+        'init-declarations': 0,
+        // disallow the catch clause parameter name being the same as a variable in the outer scope
+        'no-catch-shadow': 2,
+        // disallow deletion of variables
+        'no-delete-var': 2,
+        // disallow var and named functions in global scope
+        'no-implicit-globals': 2,
+        // disallow labels that share a name with a variable
+        'no-label-var': 2,
+        // disallow self assignment
+        // http://eslint.org/docs/rules/no-self-assign
+        'no-self-assign': 2,
+        // disallow shadowing of names such as arguments
+        'no-shadow-restricted-names': 2,
+        // disallow declaration of variables already declared in the outer scope
+        'no-shadow': [0, {'builtinGlobals': false, 'hoist': 'functions', 'allow': []}],
+        // disallow use of undefined when initializing variables
+        'no-undef-init': 0,
+        // disallow use of undeclared variables unless mentioned in a /*global */ block
+        'no-undef': 2,
+        // disallow use of undefined variable
+        'no-undefined': 0,
+        // disallow declaration of variables that are not used in the code
+        'no-unused-vars': [2, {'vars': 'all', 'args': 'after-used'}],
+        // disallow use of variables before they are defined
+        'no-use-before-define': [2, {'functions': false, 'classes': true}],
+        // require spaces around operators
+        'space-infix-ops': 2,
+        // require use of semicolons where they are valid instead of ASI
+        'semi': [2, 'always'],
+        // Disallow duplicate imports
+        'no-duplicate-imports': 2,
+        // Disallow unnecessary escape usage
+        'no-useless-escape': 2,
+        // Creating objects with duplicate keys in objects can cause unexpected behavior in your application
+        'no-dupe-keys': 2,
+
+        'arrow-body-style': [2, 'as-needed'],
+        // require parens in arrow function arguments
+        'arrow-parens': 0,
+        // require space before/after arrow function's arrow
+        'arrow-spacing': [2, {'before': true, 'after': true}],
+        // require trailing commas in multiline object literals
+        'comma-dangle': [2, 'never'],
+        // verify super() callings in constructors
+        'constructor-super': 0,
+        // enforce the spacing around the * in generator functions
+        'generator-star-spacing': 0,
+        // disallow modifying variables of class declarations
+        'no-class-assign': 0,
+        // disallow arrow functions where they could be confused with comparisons
+        'no-confusing-arrow': 0,
+        // disallow modifying variables that are declared using const
+        'no-const-assign': 2,
+        // disallow symbol constructor
+        'no-new-symbol': 2,
+        // disallow specific globals
+        'no-restricted-globals': 0,
+        // disallow specific imports
+        'no-restricted-imports': 0,
+        // disallow to use this/super before super() calling in constructors.
+        'no-this-before-super': 0,
+        'no-var': 2,
+        // disallow unnecessary constructor
+        'no-useless-constructor': 2,
+        'object-shorthand': [2, 'always'],
+        // suggest using arrow functions as callbacks
+        'prefer-arrow-callback': 0,
+        // suggest using of const declaration for variables that are never modified after declared
+        // destructuring:all means if some variable within destructuring is modified later(let), even if others never(const), whole destructuring can be defined as let
+        'prefer-const': [2, {'destructuring': 'all'}],
+        // suggest using the spread operator instead of .apply()
+        'prefer-spread': 2,
+        // suggest using Reflect methods where applicable
+        'prefer-reflect': 0,
+        // use rest parameters instead of arguments
+        'prefer-rest-params': 2,
+        // suggest using template literals instead of string concatenation
+        'prefer-template': 0,
+        // disallow generator functions that do not have yield
+        'require-yield': 0,
+        // import sorting
+        'sort-imports': 0,
+        // enforce usage of spacing in template strings
+        'template-curly-spacing': 2,
+        // enforce spacing around the * in yield* expressions
+        'yield-star-spacing': [2, 'after'],
+
+        // babel inserts `'use strict';` for us
+        'strict': [2, 'never'],
+
+        // specify the maximum depth that blocks can be nested
+        'max-depth': [0, 4],
+        // limits the number of parameters that can be used in the function declaration.
+        'max-params': [0, 3],
+        // specify the maximum number of statement allowed in a function
+        'max-statements': [0, 10],
+        // disallow use of bitwise operators
+        'no-bitwise': 0,
+        // disallow use of unary operators, ++ and --
+        'no-plusplus': 0,
+    }
+};

.npmrc

@@ -1,2 +1,2 @@
-registry = http://registry.npmjs.org
+registry = https://registry.npmjs.org
 save-exact=true

config/browsers.config.js

@@ -1,4 +1,3 @@
-'use strict';
 module.exports = function (config/* , appRequire */) {
     config.browsers = {
 

config/default.config.js

@@ -1,7 +1,5 @@
 // Default server configuration
-'use strict';
-
-var ms = require('ms');
+const ms = require('ms');
 
 module.exports = {
     env: 'development', // Enviroment: development, testing, production

config/server.js

@@ -8,7 +8,7 @@
  *
  * You can override any specific parameter through console, for example, --no-gzip
  */
-'use strict';
+'use strict'; // eslint-disable-line strict
 
 const os = require('os');
 const fs = require('fs');

controllers/coreclient.js

@@ -1,14 +1,13 @@
 import net from 'net';
-import _ from 'lodash';
 import EventEmitter from 'events';
 
 export class Client extends EventEmitter {
-    constructor(logger) {
+    constructor(logger, ...args) {
         super();
 
         this.logger = logger || console;
         this.socketClosed = true;
-        this.connectargs = _.toArray(arguments);
+        this.connectargs = args;
         this.promiseDescriptors = new Map();
     }
 

controllers/mail.js

@@ -9,7 +9,7 @@ const { env, mail: mailConf } = config;
 
 const logger = log4js.getLogger('mail.js');
 const logoBuf = new Buffer('iVBORw0KGgoAAAANSUhEUgAAAC8AAAAxCAIAAADFmWcQAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAAnkSURBVFhHzZjbcxPXHcf7X/StoTN96PShD512MkMN2LIs2ZIlS7KktaTVSitLWl1sWbJkfMVYNhhsx9xTcLhMJ/SlDJP0oeT+kF5SJjQPLQkhaQgEjO8YY4Ppa7+/PevVai0bwmSmzHxnRz7ec87n/G7n7PnRTy29L49eepodDT3ys1vb+INrR/1eXQukpwEKo9legi19xJ14j5duivG5uLScSCwlktNdPUGLNFrliNQEde8/pzbTbGeSWFP6nUD8QTyO6ZeTyYfp9HIm8zCXg1YKhdVisc/ET+/87azFMme3v2tviZsjuhEqake9MmklT1WyYY8rdTOicACCTb/S1fWouxta6elZHRw8Heo4v8d232icdzoXfL55rxfPr9zcgFXUjbaVSjSqVXaYu9RGyGFt+zIilXHIECDQau3AAakx9sUew6zVCoilUAhaDAYXeR666eM95ph2WJ2YCRQahoImHcqENwUOQoFfZA4twaO+PkX9/Z/3DqaMgfu1tfMez1I4/CAWg5ZaW/GbsHh+we8/ag9rB98solGSaMNBr5jy7MflFk2I5HJaezACVTDMMb7tXI0dEYNZAUG9Egm2EsbE7PRn13YBzmi6N1vlowCtDGMx71B8aCyhE2gyFuHvu43zDgcmVnwqCyuBFCbZSH/x8NqJtNrwVHnkXvbSamBqrYMqckCr+/ZdLfTnjdwdQy0ilxbQ1qaXjEW+k4Heba5sIdk25SijdloEszahFAqKYTZxMMEwb4bSUzU2uAkdaQE6FKZyoCM2QTspk0yj8VFTXXyhuRlvgwZDMBQyzCYIVaDpsApv7zHDTZisjEAnGUh1mbtOX40UT6n6V4MdhQsGh6fQ+XloloeH0XF8dyMSe0vDqEIwpVIPOztXenu/6+7XTg2V0TjNEkacs9lU86DUbu8m6GqhD309r9qRNTSZbnqNMBQM+fi116C1gwdX9+8v+jNaAKJRU/qAmT9k8s/6fKBB2QAQBfKzgAa4BOs+K4q66ZlWMhlE+pPJyScnTjw5fnz96NEnR448PnwYO8lMD61EVck2glFE7bpocnMG4SM3z0o7lssCiIA2cTCpI/zJG9ZCQCudnTDG+qlT66+/jqdCc+wY0YyP41+gTLpS6gglmnfqXYgY1PVPTY1+A3+8gao7mMhCkQiGrmihf2dLGeA3+FRPIdQeT0ysT02tnzmzfvp0BZqJiceHDsE8H7cV1BFKNOCg3Q4+cjqRqwVjS7Lacz2gFHWqackk7ZTlET3kldQRfvwbDhxr+/dj4qfnzj09e/bp1jTkuMOH14aHHw0MqCMoNC21IqNBuDAB6PcGO7fLfanJx+q6UmRRgTSVUB2I6R/Fsf+ePw8Rytmzim2mpqjlwoV1PEH5xhtKO/iOHl0bGxNdbay7QjNm5FgqEYrXywTHfVZn6ahxm19tclY1i7UtMWOLZA5I1lCiUexwRFut+oLx890ht6ut0ZawNEoWa7yhMV5nif1qT+CXO7mkPZKxi202Md0YZkpZw+2NYtERsRhCrLtC80Fd02YaErxmtU5W29lrL6xjLdJsvnA3l7/Tnr2Tar+TbLstJW/HpDuR2GJcuhJU3K3QfFNvqUwDocXpvGW17fn1izBVVQfvdymbP+VBVxf5OpNZZnUZG0U0+k04yl5WaG6b6+mUVJFGlcczUO1k7z+nRviO1eHhtaEhnAxXBwYo1Hp7H+3di2x4mM0up+jwBJrpSDnNLRPRKFGsg9AI+fW3VO4XVQHWa3t90jdMZXd8HIVubXSUqsvwMOovagzZae9eAmpvR2bMS+WeYrbZjobj0Bnx/xiZOTmZ5NpZx4qK+QuULydPrp88SVktF98n2A3Q/dAhYMFaSGw4DuURLptNKgVQofnaaCYah6MiDbxLBscqUbLkXebawAjrWFF/6DrACoxCo6kxZCoVqLeXClgmcyNeTnOlrgkFRqHRAC0KAjZb9Cdrj40REGgmJnr4LOtYUc3N2coocl9G82hoCCPTOS6T+VBMso4KzWitd8ZsRoGhQGYoHIf9cnVkBJsteR1AMhPD+tnOLU+TTLfGNvZIoDBPMZrxcSrB8gaOEsps8zsuznopNN5qYcZkUkMHZRfxT0E3MsKAaEGjo/QcGbmaL9t4oQmxYGhQ1sd0oWOwMspG6LBYpuTq7ORM5dUPIhrZWQhyvErBXyyWgOBpPOHs/v6cs+zL6FpB5i4W2zxloQ2aMhT4CPu2TEMj79tHUQxP5ZXzDFSieavWBsPAbpR+8tkbrqVushgHraartGm3OhJoV4WKcjFUAlqcrIQCX8Pvck6tyIXng1Zlk4JKNJ66CJ0HslnlCwFAAwOlqoWeKKOdnVdjafb++UgH/Vcjws3nbyTadtWQ5U+k+mAbPQrcdPAghbC8MLwfsZS+i0s00M1WiYDkTxaq4oh5VqY6O6lSZTI4MBh3cXjzer6HvKkVoPF+Po8RFpJJwUxAcJYeZXQUblWKTZ62LXV2qIwmbo0tSzJQNksEuRwjYHvKg1RqqDEYt4ZWNg43Wik0iMp0ejGRWJCkuCnwxchh0JQcxCoyrIhskg3TZS87BZTRQNeEKIAwN9MDie4DFmKxf4ainmruuE+CGahOYLvRiP7EBDB+Po/dZ0mS5mOxtzhxhG9X8khFKRaJXjbMl8lSxDDpaUzG1iVRxNGTJIrzkch8a+uUI9hs8H+SzmHiVbYVbyHM8SCRWIzF5qPR20JYtIQobuQCQ1mJgo4yw0yYy1kN+i9OPQ3Uaw3PCgJ0XxC+Coaz5kDOFl7oovgn88pCMOnE2sm/6TQO9nORyJwodhq9f+0eJMMwFFZ/ZZSDrlbdvFAFGujNJn6a5680835D4EIggUMJFl0mkKlw7Ddrxy6IcwJQwuHZUOiSwz/qTxGNjAIfIauB8ragfPToVJkG6m0IHnG13pAoxSioIflGjVYvSyVTW5Q3GY0gzAjCZx5fqiFIeQQHbaC8F6qMAhHNK+bSN4RWF33yJRL7ImlvR2FUsLYREhAnOlGc4/lpv38mEBio836c7UbsI6pA/MeAsiVV1Ja2YRq0icgp5T4GM+FwtCGq2hpRYypFbkIaiiI4pn2+uxx3xuI9J6QRubDKAeczLiWfQQPV1YQ+9cl3ORuZT5/1G19xJLkakdh9lnwngs/ne17vXa/3a7f3fHP4WiLjND772pZodPc3FRU1Cdf9oUWkfTRKggG0isXQSFchoki3IYHAjNf7ndv9rcv1ucNlrKLy/Tx6tm20ajIEL7t4zIcjBwlzsx/qDWgwiI/lBY6bcbsvWZrtVR7dCNvr+9Go8hkCJxoD7zcH/uPn7wX4e/7APZ//W2/Lhw7uVL2X3/39IFS9IM0PpZ8Yt941/+96mWgsvf8DmSRLPdhPjjUAAAAASUVORK5CYII=', 'base64');
-const emailValidator = /^(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
+const emailValidator = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@(([[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
 export const sender = {
     noreply: 'PastVu ★<[email protected]>'
 };

controllers/middleware.js

@@ -58,9 +58,9 @@ export function responseHeaderHook() {
             next = Utils.dummyFn;
         }
 
-        res.writeHead = function () {
+        res.writeHead = function (...args) {
             res.setHeader('X-Response-Time', `${Date.now() - start}ms`);
-            writeHeadOriginal.apply(res, arguments);
+            writeHeadOriginal.apply(res, args);
         };
         next();
     };

controllers/profile.js

@@ -22,7 +22,7 @@ const privateDir = path.join(config.storePath, 'private/avatars/');
 const publicDir = path.join(config.storePath, 'public/avatars/');
 const mkdirpAsync = Bluebird.promisify(mkdirp);
 const execAsync = Bluebird.promisify(exec);
-const emailRegexp = /^(([^<>()[\]\\.,;:\s@\"]+(\.[^<>()[\]\\.,;:\s@\"]+)*)|(\".+\"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
+const emailRegexp = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@(([[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
 
 const getUserByLogin = async function (login) {
     const usObjOnline = session.getOnline({ login });