-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NServiceBus step by step tutorial cleanup #6903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Nov 10, 2024
tutorials/nservicebus-step-by-step/2-sending-a-command/Snippets/Core_9/Exercise.cs
Show resolved
Hide resolved
andreasohlund
commented
Nov 10, 2024
andreasohlund
commented
Nov 10, 2024
tutorials/nservicebus-step-by-step/1-getting-started/tutorial.md
Outdated
Show resolved
Hide resolved
@nix-bohon FYI since I know you are going through the tutorials |
DavidBoike
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments
tutorials/nservicebus-step-by-step/1-getting-started/tutorial.md
Outdated
Show resolved
Hide resolved
tutorials/nservicebus-step-by-step/2-sending-a-command/Snippets/Core_9/Exercise.cs
Show resolved
Hide resolved
tutorials/nservicebus-step-by-step/5-retrying-errors/tutorial.md
Outdated
Show resolved
Hide resolved
Co-authored-by: David Boike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of preparing to run the 2-day NSB course, I went through the tutorials and found some things to clean up.
All solutions have been smoke-tested
I will make corresponding changes to https://github.com/Particular/Workshop.NServiceBus
Related cleanup of the saga tutorial #6898