Move all monitoring.py logging to lazy format style #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is based on a review comment from @khk-globus on PR #3672
benclifford
force-pushed
the
benc-monitoring-log-lazy
branch
from
9ac7693
to
0e65d78
Compare
khk-globus
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Heh, you're so disciplined! Nothing in piecemeal fashion for you ...
When I'm fairly confident the log will be emitted somewhere, I often will stay with the "format now" approach — my thinking being that there is no sense in passing extra pointers and/or data structures around in memory. In this case, that would likely mean that the .info(), .error(), and .exception() calls don't need to be updated. Meh.
No biggie, just observing
yeah I am pretty fine with that, but I find having two different styles a bit grating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is based on a review comment from @khk-globus on PR #3672
Changed Behaviour
logging formatting should come out the same but maybe not
Type of change