Remove unused re-used DFK default configuration object #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
approved these changes
Aug 14, 2023
The default configuration actually comes from DataFlowKernelLoader.load() and the Config() object specified in the DataFlowKernel.__init__ default parameters is never used, as all constructions of DataFlowKernel in the codebase specify a config. This comes from flake8-bugbear
khk-globus
force-pushed
the
benc-dflow-no-default-config
branch
from
6d0b2ae
to
19d93c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration actually comes from
DataFlowKernelLoader.load()and theConfig()object specified in theDataFlowKernel.__init__default parameters is never used, as all constructions of DataFlowKernel in the codebase specify a config.This comes from flake8-bugbear
Type of change