Remove executor-level error management enable/disable #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this PR, calls to handle_errors are always enabled, and it is the responsibility of the handle_errors implementation to ignore errors if the user has so chosen. The BlockProviderExecutor handle_errors implementation already has a test for that (duplicating the test in the now removed error_management_enabled code) so nothing needs to change there: this code only removes the redundant code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, calls to handle_errors are always enabled, and it is the responsibility of the handle_errors implementation to ignore errors if the user has so chosen.
The BlockProviderExecutor handle_errors implementation already has a test for that (duplicating the test in the now removed error_management_enabled code) so nothing needs to change there: this code only removes the redundant code path.
Type of change