Skip to content

Commit

Permalink
Remove unused (multi)channeled marker types
Browse files Browse the repository at this point in the history
These were introduced to help make channels easier to typecheck in the
DFK, but the DFK code continued to use hasattr tests for 'channel' and
'channels' attributes rather than these marker types.

This is part of channel removal, issue #3515
  • Loading branch information
benclifford committed Oct 24, 2024
1 parent 72f275f commit 83f3b64
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions parsl/providers/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from abc import ABCMeta, abstractmethod, abstractproperty
from typing import Any, Dict, List, Optional

from parsl.channels.base import Channel
from parsl.jobs.states import JobStatus

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -154,18 +153,3 @@ def status_polling_interval(self) -> int:
:return: the number of seconds to wait between calls to status()
"""
pass


class Channeled():
"""A marker type to indicate that parsl should manage a Channel for this provider"""
def __init__(self) -> None:
self.channel: Channel
pass


class MultiChanneled():
"""A marker type to indicate that parsl should manage multiple Channels for this provider"""

def __init__(self) -> None:
self.channels: List[Channel]
pass

0 comments on commit 83f3b64

Please sign in to comment.