Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix magic touch spells false deleting, fix spelling, allow escape #27736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Qwertytoforty
Copy link
Contributor

What Does This PR Do

Magic touch spells no longer trigger and kill themselfs on floors or walls or lockers or holopads, etc.
Fixes spelling in plasmaman plush.
Allows sword / bread / plush spirits to break out of storage objects with a 50% chance. Makes it less harsh for crew.

Why It's Good For The Game

Losing your spell charge because you missclicked is bad.
Spelling right good.
Allowing plushes to break out of bags 50% of the time their throw spell is good to make it less shitty for the victim.

Testing

clicked on everything with touch spells
Confirmed only activated on valid targets (basically everything for xeno acid, mobs for other things)
Confirmed could break out of backpacks and also fail to break out.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
fix: Touch spells no longer false triggers on floors or lockers or other things.
fix: Fix plasmaman plush spelling.
tweak: Sword / bread / plush spirits can break out of storage objects 50% of the time.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants