Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a variable to use defines, also some autodoc improvements #27725

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Change a variable to use defines, also some autodoc improvements #27725

merged 4 commits into from
Dec 30, 2024
+27 −25

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Dec 23, 2024

What Does This PR Do

  • Makes a variable use defines instead of pretending to be flags
  • Removes some unused variables
  • Improves autodocs

Why It's Good For The Game

More clean code

Testing

It compiled

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPCF (I hope)

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Dec 23, 2024
@Burzah Burzah added the Code Improvement This PR will improve the code quality of the codebase label Dec 23, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 23, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Dec 28, 2024
@Burzah Burzah added this pull request to the merge queue Dec 30, 2024
Merged via the queue into ParadiseSS13:master with commit c4a84a9 Dec 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Burzah Burzah Burzah approved these changes

@Sirryan2002 Sirryan2002 Sirryan2002 approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Code Improvement This PR will improve the code quality of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DGamerL @Sirryan2002 @Burzah @ParadiseSS13-Bot