Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reagent list syntax in flowers.dm and correct typo in config.toml #27699

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix reagent list syntax in flowers.dm and correct typo in config.toml #27699

wants to merge 3 commits into from
+2 −2

Conversation

PGrayCS
Copy link

@PGrayCS PGrayCS commented Dec 21, 2024 •
edited
Loading

What Does This PR Do

Changes my config.toml to be in the correct place

updates the nutriment to be of typepath string rather than typepath. fixes #27678

Why It's Good For The Game

Fixes issue #27678

Images of changes

n/a

Testing

tested on my version

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑

fix: Fixed a few things
Updated the nutriment to be of typepath string.
/:cl:

DGamerL
DGamerL reviewed Dec 21, 2024
View reviewed changes
config/example/config.toml Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Configuration Change This PR changes the game configuration files. Please run via the host. labels Dec 21, 2024
DGamerL
DGamerL reviewed Dec 21, 2024
View reviewed changes
config/example/config.toml Outdated Show resolved Hide resolved
@PGrayCS @DGamerL
Update config/example/config.toml
36517aa 
Co-authored-by: DGamerL <[email protected]>
Signed-off-by: PGray <[email protected]>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 21, 2024
@DGamerL
Copy link
Member

DGamerL commented Dec 21, 2024

fix: Fixed a few things

You should be a bit more descriptive here, for the rest, looks good!

@PGrayCS
Copy link
Author

PGrayCS commented Dec 21, 2024

fix: Fixed a few things

You should be a bit more descriptive here, for the rest, looks good!

Thanks, had alook at this now :)

@PGrayCS PGrayCS requested a review from DGamerL December 21, 2024 22:26
@PGrayCS
Merge branch 'master' into fix-for-ParadiseSS13#27678---Spaceman's-tr…
afb40fc 
…umpets-dont-correctly-give-the-nutritment-reagent
@DGamerL
Copy link
Member

DGamerL commented Dec 21, 2024

I'd suggest this:
fix: Spaceman's trumpet now gives nutriment again as it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fordoxia Fordoxia Fordoxia left review comments

@AffectedArc07 AffectedArc07 AffectedArc07 approved these changes

@DGamerL DGamerL Awaiting requested review from DGamerL

Assignees

@AffectedArc07 AffectedArc07

Labels
-Status: Awaiting review This PR is awaiting review from the review team Configuration Change This PR changes the game configuration files. Please run via the host.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spaceman's trumpets dont correctly give the nutritment reagent
5 participants
@PGrayCS @DGamerL @AffectedArc07 @Fordoxia @ParadiseSS13-Bot