[PORT] Add mantis blades (new traitor item) #27594

MiraHell · 2024-12-09T14:13:36Z

What Does This PR Do

Adds a new traitor item acquirable through any uplink for 60 TC. For your TC, you receive a box. Inside the box are two autodocs, one for each arm. Once used, they will implant a set of two retractable blades into your body. The Syndicate version deals 20 damage and has 30 armor penetration, while the NT version deals 18 damage and has no armor penetration.
These blades can parry non-projectile attacks, with the Syndicate version having a 75% uptime and the NT version having a 60% uptime. With a cooldown of 1.5 seconds (every second attack), both blades will attack at once. They can also pry open doors when used together. A Nanotrasen version is included and can be printed on a protolathe with Syndicate Tech level 6.

Why It's Good For The Game

A new traitor item with cyberpunk vibes and new double attack mechanics, a more stealthy but weaker weapon than the dsword or chainsaw.

Images of changes

On the right is the NT version and the left is syndie

Testing

Spawned uplink, bought mantis blades kit, implanted myself, spawned dummy, killed it with blades, spawned airlock, pryed it with two blades. Printed the NT version on protolate, implanted the monkey with it.

Declaration

I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added new traitor item: mantis blades, NT version included on syndicate tech 6
/:cl:

original author: EdgeLordExe
tgstation/tgstation#55936
author of yogstation port: enkidienne
yogstation13/Yogstation#11946

Toastical · 2024-12-09T14:34:16Z

Is the double attack cooldown intended to be separate to each arm? Switching your attacking hand allows you to do 2 double attacks back to back consistently.

I cannot tell if the video works.

2024-12-09.16-32-23.mp4

MiraHell · 2024-12-09T14:53:42Z

Is the double attack cooldown intended to be separate to each arm? Switching your attacking hand allows you to do 2 double attacks back to back consistently.

It's not intended, thanks for noticing. I'll try to redo the double attack, linter doesn't like the attack call in pre_attack

I cannot tell if the video works.

Works

MiraHell · 2024-12-09T19:52:46Z

I need help with the attack chain, I don't understand how it needs to be done

DGamerL · 2024-12-10T02:18:05Z

I'll try to help tomorrow!

MiraHell · 2024-12-10T09:26:02Z

Thanks Warriorstar for the help with nested types. I'm also planning to add the ability to pry open doors with two blades, and then the PR will be ready for review.

MiraHell · 2024-12-10T10:04:35Z

Ready for review ✨

DGamerL · 2025-01-01T04:21:34Z

Sorry that it's taken so long, I'll take a proper look tomorrow, happy new years!

code/game/machinery/doors/airlock.dm

code/modules/surgery/organs/augments_arms.dm

Co-authored-by: Burzah <[email protected]> Signed-off-by: Mira <[email protected]>

code/modules/surgery/organs/augments_arms.dm

PopeDaveThe3th

Lore & description pass.

code/datums/uplink_items/uplink_general.dm

code/game/objects/items/weapons/storage/uplink_kits.dm

code/modules/research/designs/weapon_designs.dm

code/modules/surgery/organs/augments_arms.dm

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Drsmail

LGTM

code/modules/surgery/organs/augments_arms.dm

code/datums/uplink_items/uplink_general.dm

lewcc

One thing, though it's not tiny.

lewcc · 2025-01-10T21:26:17Z

code/game/machinery/doors/airlock.dm

+	else if(!ispowertool(I) && !istype(I, /obj/item/melee/mantis_blade))
 		to_chat(user, "<span class='warning'>The airlock's motors resist your efforts to force it!</span>")
 		return
+	if(istype(I, /obj/item/melee/mantis_blade))
+		var/obj/item/melee/mantis_blade/secondblade = user.get_inactive_hand()
+		if(!istype(secondblade, /obj/item/melee/mantis_blade))
+			to_chat(user, "<span class='warning'>You need a second [I] to pry open doors!</span>")
+			return


Hmm, this feels a bit snowflakey. I think it'd be best to make a quick door-forcing a component with some signals, if you could, and have it applied to items that can force doors.
Feel free to reach out on discord if you have any questions.

Yes, I thought about it, entire airlock.dm is bit snowflakey, but it seemed to me that it was out of the scope of this PR. But I'll think about how this can be done

code/modules/surgery/organs/augments_arms.dm

MiraHell · 2025-01-11T15:10:41Z

Draft while I'm working on the component

MiraHell added 4 commits December 9, 2024 16:34

add mantis blades

48040b4

fix nuclear only

17dbdcd

fix .dme edit

77d6d5e

fix linter

f218a3e

MiraHell added 2 commits December 9, 2024 21:20

new attack chain

fa1d151

maybe fix linter

afb4080

ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 9, 2024

add NT mantis blade to syndicate 6

4e9bc78

MiraHell added 2 commits December 9, 2024 22:56

newline

8745ed0

add list

2c89aab

fix nested types

52e9e56

ability to pry open doors with two blades

34db8cd

DGamerL added the Balance This PR will modify how effective something is or isnt label Dec 19, 2024

Burzah requested changes Jan 1, 2025

View reviewed changes

MiraHell and others added 2 commits January 2, 2025 15:09

Update code/game/machinery/doors/airlock.dm

fdc5d30

Co-authored-by: Burzah <[email protected]> Signed-off-by: Mira <[email protected]>

requested changes

58ae82c

MiraHell requested a review from Burzah January 2, 2025 12:25

Drsmail reviewed Jan 2, 2025

View reviewed changes

code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved

PopeDaveThe3th suggested changes Jan 2, 2025

View reviewed changes

MiraHell and others added 11 commits January 2, 2025 18:33

Update code/datums/uplink_items/uplink_general.dm

5617374

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/datums/uplink_items/uplink_general.dm

4357c9b

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/game/objects/items/weapons/storage/uplink_kits.dm

92008fc

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/research/designs/weapon_designs.dm

5b027a5

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/research/designs/weapon_designs.dm

69a217a

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

5f3bb65

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

79e3662

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

7b9c1d1

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

ab4d355

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

5231b58

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Update code/modules/surgery/organs/augments_arms.dm

0586280

Co-authored-by: PopeDaveThe3th <[email protected]> Signed-off-by: Mira <[email protected]>

Drsmail approved these changes Jan 2, 2025

View reviewed changes

PopeDaveThe3th approved these changes Jan 2, 2025

View reviewed changes

MiraHell added 3 commits January 2, 2025 20:24

add safetys and some cleanup

686347d

return parry sound

4e11cf1

snake case and replace CALLBACK with VARSET_CALLBACK

178dd9c

lewcc reviewed Jan 8, 2025

View reviewed changes

code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved

code/datums/uplink_items/uplink_general.dm Show resolved Hide resolved

move attacking logic and update item and uplink description

0097e9d

MiraHell requested a review from lewcc January 9, 2025 02:18

cleanup

26f2d7e

lewcc reviewed Jan 10, 2025

View reviewed changes

Toastical reviewed Jan 10, 2025

View reviewed changes

code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved

MiraHell marked this pull request as draft January 11, 2025 15:10

MiraHell added 4 commits January 11, 2025 18:13

first attempt

a71e003

fix conditional statement

5b316c2

update paradise.dme

36ce151

edit whitespace

4b922ff

MiraHell requested a review from lewcc January 11, 2025 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PORT] Add mantis blades (new traitor item) #27594

[PORT] Add mantis blades (new traitor item) #27594

MiraHell commented Dec 9, 2024 •

edited

Loading

Toastical commented Dec 9, 2024 •

edited

Loading

MiraHell commented Dec 9, 2024

MiraHell commented Dec 9, 2024

DGamerL commented Dec 10, 2024

MiraHell commented Dec 10, 2024 •

edited

Loading

MiraHell commented Dec 10, 2024

DGamerL commented Jan 1, 2025

PopeDaveThe3th left a comment

Drsmail left a comment

lewcc left a comment

lewcc Jan 10, 2025

MiraHell Jan 10, 2025

MiraHell commented Jan 11, 2025

[PORT] Add mantis blades (new traitor item) #27594

Are you sure you want to change the base?

[PORT] Add mantis blades (new traitor item) #27594

Conversation

MiraHell commented Dec 9, 2024 • edited Loading

What Does This PR Do

Why It's Good For The Game

Images of changes

Testing

Declaration

Changelog

Toastical commented Dec 9, 2024 • edited Loading

MiraHell commented Dec 9, 2024

MiraHell commented Dec 9, 2024

DGamerL commented Dec 10, 2024

MiraHell commented Dec 10, 2024 • edited Loading

MiraHell commented Dec 10, 2024

DGamerL commented Jan 1, 2025

PopeDaveThe3th left a comment

Choose a reason for hiding this comment

Drsmail left a comment

Choose a reason for hiding this comment

lewcc left a comment

Choose a reason for hiding this comment

lewcc Jan 10, 2025

Choose a reason for hiding this comment

MiraHell Jan 10, 2025

Choose a reason for hiding this comment

MiraHell commented Jan 11, 2025

MiraHell commented Dec 9, 2024 •

edited

Loading

Toastical commented Dec 9, 2024 •

edited

Loading

MiraHell commented Dec 10, 2024 •

edited

Loading