Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaceman's trumpets dont correctly give the nutritment reagent #27678

Open
1 task done
Contrabang opened this issue Dec 19, 2024 · 0 comments · May be fixed by #27699
Open
1 task done

Spaceman's trumpets dont correctly give the nutritment reagent #27678

Contrabang opened this issue Dec 19, 2024 · 0 comments · May be fixed by #27699
Labels
Bug This is a bug in our game code Good First Issue This issue is easily fixable and could be worth handing to a new contributor

Comments

@Contrabang
Copy link
Contributor

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

N/A

Issue Description

This should be a string, not a typepath

Paradise/code/modules/hydroponics/grown/flowers.dm

Line 76 in 18604d9

reagents_add = list(/datum/reagent/consumable/nutriment = 0.05)

What did you expect to happen?

String not typepath

What happened instead?

typepath

Why is this bad/What are the consequences?

its bad code

Steps to reproduce the issue.

  • look at code
  • cry

When did the problem start happening?

since these seeds were ported from tg

Extra information

No response

Relevant log output/runtime error


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            


    

    

      
    

    


      

          @Contrabang
Contrabang




          added
  the 

  Bug

  This is a bug in our game code
 label


      Dec 19, 2024

    

  



    


    

    

      
    

    


      

          @Contrabang
Contrabang




          added
  the 

  Good First Issue

  This issue is easily fixable and could be worth handing to a new contributor
 label


      Dec 19, 2024

    

  



  

  

    
  


  

      

  This was referenced Dec 20, 2024





  


  

      
   Closed

  






      






  


  

      
   Open

  






  




  


  
    
  
  

    
  PGrayCS 

      added a commit
        to PGrayCS/Paradise
      that referenced
      this issue

    
      Dec 21, 2024
    
    

      


  

    

      


  

      
        @PGrayCS
  





      

        
          Merge branch 'master' into fix-for-ParadiseSS13#27678---Spaceman's-tr…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          afb40fc
        
      

    

  

    

      
…umpets-dont-correctly-give-the-nutritment-reagent

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                    




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    Bug

  This is a bug in our game code
  

    Good First Issue

  This issue is easily fixable and could be worth handing to a new contributor








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Paradise Station Issue Tracker
        
    

    

      

            
    Status: Cause Known

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  



      

    

  
      

  

    

      1 participant
    

    

        
          @Contrabang