Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Showtime icon #3811

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Raindrac
Copy link

Adds an icon Showtime, the incubating replacement for Gnome's Totem video player.

Showtime's original icon is heavily inspired by the Totem icon, so I went in that direction and used the Totem icon as the template. I could've just recolored it, but I found myself a tad uncomfortable with all the misaligned nodes, so I spent around two hours lining them up as best as I could. It's still not perfect, and in hindsight, I should've just stuck with recoloring it or remade it from scratch like I did for Clapper.

Either way, the nodes are a lot cleaner and more aligned than they would've been, and I made sure that every straight line is perfectly aligned to the grid, so nobody will ever notice the sub-pixel misalignments unless they zoom in on the .svg. Good enough! If there's interest, I can backport the node alignment improvements that I made for Showtime onto the Totem icon.

I decided against adding the movie film present in the original Showtime icon because I feel like it detracts from the logo design. It looks better without it, imo.

@morganist
Copy link
Contributor

Hi,
The icons you've tweaked contain instances of transform="translate" and transform="matrix". I get that you've been trying to fix the alignment, but the result is as messy as the Totem icon but at the same time less compatible and more complicated. Do you think remaking this pull request as a simple recolouring of the Totem icon (preferably in the text editor) would work for you? Like the colours, by the way!

@Raindrac
Copy link
Author

I could remake it as a simple recolor, but I've gotta say that it wouldn't feel right for me to submit a new icon that has some alignment issues.

If I managed to remake both the Totem and Showtime icons from scratch without alignment issues and without the use of translate and matrix transformations, would it be approved? If so, I'll look into whether I could pull it off. Otherwise, I'll go forward with a simple recolor.

@morganist
Copy link
Contributor

morganist commented Sep 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants