Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for Crystal source files #3762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BigBoyBarney
Copy link

This is my first icon-set, so any feedback is very welcome!!

Thanks!

@morganist
Copy link
Contributor

it looks good! can you please change the elements to use Papirus colours - #e4e4e4 for white, #4f4f4f for dark grey (you can use a lighter grey, but please not in rgb format). also, the inner triangle could be better aligned to the pixel grid. for a bit of streamlining, it would be better if the elements are not grouped.

@BigBoyBarney
Copy link
Author

Thank you for looking at it! I'll take a look at the triangle, but it's a bit tough without changing the shape of the logo too much. Regarding the colours, the template itself was #fafafa for white:
from [email protected]

<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" version="1.1">
 <path style="opacity:0.2" d="M 6.375,3 C 5.61325,3 5,3.6244 5,4.4 V 29.6 C 5,30.37504 5.61325,31 6.375,31 h 19.25 C 26.3862,31 27,30.37504 27,29.6 V 12 L 20,10 18,3 Z"/>
 <path style="fill:#e4e4e4" d="M 6.375,2 C 5.61325,2 5,2.6244 5,3.4 V 28.6 C 5,29.37504 5.61325,30 6.375,30 h 19.25 C 26.3862,30 27,29.37504 27,28.6 V 11 L 20,9 18,2 Z"/>
 <path style="opacity:0.2" d="M 27,12 18,3 v 7.59375 C 18,11.373375 18.62775,12 19.40625,12 Z"/>
 <path style="fill:#fafafa" d="M 27,11 18,2 V 9.59375 C 18,10.373375 18.62775,11 19.40625,11 Z"/>
 <path style="opacity:0.2;fill:#ffffff" d="M 6.375,2 C 5.61325,2 5,2.6247906 5,3.4003906 v 1 C 5,3.6247906 5.61325,3 6.375,3 H 18 V 2 Z"/>
</svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants