…inside this module.

The _ioc.py file will not live here forever, it's just easier to run and debug it from outside of the module structure, as it avoids some name clashing errors.

…s, and values.

Also contains the start of an attempted mapping from (type, subtype) -> function to create record.

… fields.

…e mechanism.

Note this doesn't work at the moment - the second GetChanges call (in update()) hangs indefinitely. I don't know why...

Note that the update() method will basically always throw exceptions as there are no records created for the fields that most commonly change.

…ords.

…implementation still doesn't let me call Get() successfully.

…ry WIP.

…n't saved anywhere yet.

…fy a command saving data into FieldInfo

It revolves around the _FieldCommandMapping class, which links together a command and the attribute in a FieldInfo class. It also handes converting the strings from PandA into more useful Python types.

The FieldInfo class and GetFieldInfo command are being slowly expanded with new attributes for various field types. At some point in the future they'll need to be broken apart.

This results in a very bloated FieldInfo structure - I'll probably sub-class it for each Type to trim it down.

Also add some notes to _ioc.py.

…tFieldInfo

… already captured in the `labels` field (which is the logic pymalcolm uses)

…butes.

Clear out commented out code and attributes.

Also a lot of other miscellaneous refactoring and comments

…t_out records.

Additional comment on from_instance method.

…s that in _ioc.py.

NOTE: Something is causing pytest to hang indefinitely after finishing tests, which is causing all kinds of problems. Investigating now...

…es a new event loop that never gets terminated

Fix associated tests.
Start work on test_get_fields_parameterized_type to test every type permutation.

Doing this after discussion with Tom, who said that there was a historical reason that these two CAPTURE attributes were treated differently in pymalcolm (which this code is based on), but that difference will be disappearing soon and so they should be treated the same.

Add missing cases to GetFieldInfo's dictionary lookup.

Note there's a bug somewhere in _make_scalar - PythonSoftIOC complains that the initial_value's type is wrong when it creates the main record, hence it's commented out at the moment.

Also identified problems with the `update` method - we can't use a string type to set most of these records. We have to know what type to set, and in the case of mbbi/mbbo records we have to set the index...

…n function between creation of the record and the later updating of its values.

A couple of other TODOs also done.

…rd creation

…data", which allows the second network round trip to be skipped if the flag is False.

Tests updated.

…de setting the fields of FieldInfo to be next to the code that does the Get request.

Note Descriptions are currently not retrieved - need to work out how to add them...

Not terribly happy with it as it means we have to replicate the Get(*DESC...) command to all type functions, and set it in every function as well. But it works...

This is generic and so will work for all types, regardless of whether we recognise them or not.

The "_command" prefix was superfluous

Minor refactoring and renaming included.

…he file.

Make _check_num_values allow more values than expected, so we are permissive to future PandA server changes.
Also misc docs and type hints added.

…return multiline table values in new `multiline_values` field of `Changes`

This commit includes always adding the block number to record names, for consistency regardless of how many blocks there are.

… by Tom Cobb.

Uses the new _RecordUpdater class, with its one method `update` to handle the logic of converting from EPICS format to PandA format data.

Also swap all `param` types and pos_out to be writeable, rather than readable.

…cted data formats without so many asserts.

Note that this doesn't completely remove the need for asserts - _execute_commands always thinks the return type is Union[str, List[str]], so we need asserts there.

And I didn't change GetState's Get commands as it's ambiguous to me what the data is supposed to be

…hen used with _execture_commands

Also add tests, and correct the GetState Get calls to GetMultiline.

…bose in many places.

Not entirely happy with just removing them though - there's a lot of places where there isn't much information at all as to what went wrong...

Pretty empty at the moment, but serves as a template for future testing.

Includes retrieving the MAX_LENGTH and FIELDS attributes from the table fields, and a new FieldInfo type to hold the returned info.

Includes some (in-progress) refactoring of the values dict so it can hold both str and List[str] items - not clear how best to do this cleanly though.

Includes some neatening up of how block and field names are created/manipulated to go between PandA and EPICS conventions.

Also changes table record creation to be handled completely separately to other fields - the List[str] was just too incompatible with the [str] type in the values dict.

Add tests.
Rename `TableFieldParams` -> `TableFieldDetails`.
Other misc comment changes

…f values for each column

…e fields

Add a test for table GetFieldInfo support. Could probably do with some more edge case tests.

…lds, and a mechanism to only Put data back based on the MODE record.

Very messy and introduces a lot of special-case processing, so needs re-architecting somewhat.

Create enum for MODE labels
Clean up the Panda/EPICS naming conventions somewhat

TableUpdater created to manage grouped table records based on its MODE record.

…ropriate sized types on pack and unpack.

…conditionally on the MODE enum

Also many docs and TODOs tidied up

…elds itself.

Alter on_update mechanism to simplify providing alternative ones.

… and pieces

Read fields are in records with initial value
Param fields are out records with initial value
Write fields are out records with no initial value

As per Tom's suggestion in PR review.

Tom spotted a missing `s`

Co-authored-by: Tom Cobb <[email protected]>

Delete associated test

It's mostly replacing print() statements, and some exceptions as well. Some DEBUG level messages added, although there could/probably should be far more of them for true debugging purposes.

Note that an awful lot of PandA field descriptions, and a lot of field labels, are too long to fit in EPICS so there are a LOT of warnings printed on startup.

A few special cases that need separate tests have not been completed yet.
A few other tests in here as well, for some standalone functions.

The controller keeps track of all the records used for configuring the data capture, along with records to control the PandA's Arm/Disarm status and one more record to enable/disable capturing.

Move ZNAM/ONAM constants into global scope as we now use them in many places.

Move setting DESC into the record creation itself, rather than a line afterwards

…'t work!

For reasons as yet unknown the first invocation works, but after cancelling the task and creating a new one it no longer runs at all.

This might break all the CI as a lot of markers have appeared again...

This reverts commit fd3920c.

Need a different package, and some packages must move out of dev-packages section

Move packages from dev to prod dependencies, for reasons not entirely clear...

Up to 64% coverage in ioc.py

Previously the clients kept a permanent connection to the server's data port, which was never closed. This meant that even if we disabled capturing by stopping the task running the data capture, the PandA was still sending data to the port that just sat in the receive buffer forever.

Also when a second call to data() was made, a second "XML FRAMED RAW" instruction was send to the PandA, which is ignored and so never responds as expected.

…pdate their values.

Also disable all Puts to In records by default.