Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bootstrap): Replace deprecated storage_account_name property #119

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(bootstrap): Replace deprecated storage_account_name property #119

merged 2 commits into from
Jan 15, 2025
+9 −9

Conversation

acelebanski
Copy link
Contributor

Description

This PR replaces deprecated storage_account_name property with storage_account_id property within the azurerm_storage_share resource.

New property was introduced in azurerm provider version 4.9 so the module's version constraints got bumped.

Motivation and Context

Property got deprecated.

How Has This Been Tested?

Deploying locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the bug Something isn't working label Jan 14, 2025
@acelebanski acelebanski requested a review from a team as a code owner January 14, 2025 15:44
@acelebanski acelebanski merged commit 234e6c7 into main Jan 15, 2025
40 checks passed
@acelebanski acelebanski deleted the deprecated-sa-name-fix branch January 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migara migara migara approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acelebanski @migara