Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual_network_gateway): Fix several issues with VNG module #117

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

acelebanski
Copy link
Contributor

@acelebanski acelebanski commented Jan 14, 2025

Description

This PR:

  • Fixes integration with public_ip module (allowing to source pip outside VNG module)
  • Fixes creating the VNG without Custom APIPA BGP peering addresses
  • Fixes the conditional check preventing from creating Generation2 VNGs

Motivation and Context

Things mentioned above didn't work properly.

How Has This Been Tested?

Manually deploying the module.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski added the bug Something isn't working label Jan 14, 2025
@acelebanski acelebanski requested a review from a team as a code owner January 14, 2025 14:08
@acelebanski acelebanski merged commit 8232a5b into main Jan 15, 2025
16 checks passed
@acelebanski acelebanski deleted the vng-public-ip-module-integration-fix branch January 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants