fix: Add 'parent_interface' parameter for l2/l3 subinterface modules #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbil
requested review from
alperenkose,
jamesholland-uk,
sebastianczech,
adambaumeister and
horiagunica
horiagunica
approved these changes
Mar 26, 2024
michalbil
force-pushed
the
subinterfaces-parent-parameter
branch
from
20d2b18 to
2a6852a
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-04-17) ### Features * Add new option to panos_active_in_ha module ([#560](#560)) ([a2870f5](a2870f5)) ### Bug Fixes * Add 'parent_interface' parameter for l2/l3 subinterface modules ([#552](#552)) ([73c28a8](73c28a8)) * **panos_facts.py:** Fixed virtual systems fact name ([#558](#558)) ([0d0fd6d](0d0fd6d))
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
github-actions bot
pushed a commit
to alperenkose/pan-os-ansible
that referenced
this pull request
Sep 24, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-24) ### Features * Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79)) * Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5)) ### Bug Fixes * Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8)) * new release for failed ci ([3872708](3872708)) * requirements.txt update python version and remove hashes ([905b1eb](905b1eb)) * **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d)) * **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot
pushed a commit
to alperenkose/pan-os-ansible
that referenced
this pull request
Sep 25, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25) ### Features * Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79)) * Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5)) * ee ci for development ([97c31ba](97c31ba)) ### Bug Fixes * Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8)) * new release for failed ci ([3872708](3872708)) * requirements.txt update python version and remove hashes ([905b1eb](905b1eb)) * **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d)) * **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
github-actions bot
pushed a commit
to alperenkose/pan-os-ansible
that referenced
this pull request
Sep 25, 2024
## [2.20.0](v2.19.1...v2.20.0) (2024-09-25) ### Features * Add additional error handling to some upgrade assurance modules ([PaloAltoNetworks#561](https://github.com/alperenkose/pan-os-ansible/issues/561)) ([c64cd79](c64cd79)) * Add new option to panos_active_in_ha module ([PaloAltoNetworks#560](https://github.com/alperenkose/pan-os-ansible/issues/560)) ([a2870f5](a2870f5)) * ee ci for development ([97c31ba](97c31ba)) * test ee ci for release ([a7605af](a7605af)) ### Bug Fixes * Add 'parent_interface' parameter for l2/l3 subinterface modules ([PaloAltoNetworks#552](https://github.com/alperenkose/pan-os-ansible/issues/552)) ([73c28a8](73c28a8)) * new release for failed ci ([3872708](3872708)) * requirements.txt update python version and remove hashes ([905b1eb](905b1eb)) * **panos_facts.py:** Fixed virtual systems fact name ([PaloAltoNetworks#558](https://github.com/alperenkose/pan-os-ansible/issues/558)) ([0d0fd6d](0d0fd6d)) * **panos_security_rule:** state merged with existing values ([PaloAltoNetworks#570](https://github.com/alperenkose/pan-os-ansible/issues/570)) ([db6c32c](db6c32c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
parent_interfaceparameter forpanos_l2_subinterfaceandpanos_l3_subinterfacemodules. The parameter is optional, except for case when state is set togathered.So far the parent interface has only been derived from subinterface name. This does not work with gathered state - for example when filter is based on the subinterface name - if it's not provided as a param, modules will fail (see linked issue).
Motivation and Context
Resolves #498
How Has This Been Tested?
Tested locally as well as using newly added integration tests.
Types of changes
Checklist