-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated @mui/system to 6.1.0 #2639
Updated @mui/system to 6.1.0 #2639
Conversation
* Replace package vm2 with isolated-vm * Removed package isolated-vm
…oundation#1668) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.7 to 3.2.8. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v3.2.8/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v3.2.8/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adding information for MongoDB retry writes feature access.
…n#1808) Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.9.6 to 6.9.9. - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.9.6...v6.9.9) --- updated-dependencies: - dependency-name: nodemailer dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n#1963) Bumps [jose](https://github.com/panva/jose) from 4.15.4 to 4.15.5. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v4.15.5/CHANGELOG.md) - [Commits](panva/jose@v4.15.4...v4.15.5) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oundation#2017) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2035) Bumps [black](https://github.com/psf/black) from 22.12.0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.12.0...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2116) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.8 to 3.2.10. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v3.2.10/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v3.2.10/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
* Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main
…2292) Bumps [black](https://github.com/psf/black) from 22.12.0 to 24.3.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.12.0...24.3.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tion#2329) * Deleted all files in the main branch in anticipation of merging develop into main cleanly * Merge develop into main --------- Co-authored-by: Peter Harrison <[email protected]>
* 20240727112603 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240727112834 Merge develop into main
* 20240929102658 Deleted all files in the main branch in anticipation of merging develop into main cleanly * 20240929103244 Merge develop into main --------- Co-authored-by: Peter Harrison <[email protected]>
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 79 files out of 281 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the WalkthroughThe Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2639 +/- ##
========================================
Coverage 97.74% 97.74%
========================================
Files 358 358
Lines 18101 18101
Branches 2600 2600
========================================
Hits 17693 17693
Misses 404 404
Partials 4 4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
(1 hunks)
package.json
Outdated
@@ -54,6 +54,7 @@ | |||
"@graphql-tools/resolvers-composition": "^7.0.2", | |||
"@graphql-tools/schema": "^10.0.6", | |||
"@graphql-tools/utils": "^10.3.2", | |||
"@mui/system": "^6.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Remove unnecessary @mui/system dependency
The @mui/system package should be removed as:
- No Material UI imports or usage found in the source code
- This is confirmed to be a backend project with no React frontend components
- While @mui/lab and @mui/material list it as a dependency in package-lock.json, these packages themselves are not declared in package.json
- The presence of vite/vitest files is only for testing purposes, not frontend development
Please remove this dependency as it's unused and inappropriate for a backend service.
🔗 Analysis chain
Investigate necessity of @mui/system in backend API.
@mui/system is typically a frontend UI package used with React applications. Its presence in a backend Node.js/GraphQL API is unusual and potentially unnecessary.
Let's verify if this package is actually used in the codebase:
Based on the PR objectives and the nature of this package, I recommend:
- If the package is unused, remove it entirely
- If it's only needed for a specific function, consider implementing that functionality directly
- If it's a transitive dependency, declare it in devDependencies or find alternative packages
Would you like me to help remove this dependency and implement any necessary functionality directly in the codebase?
Let me gather more information about the actual usage of Material UI components in the codebase.
This will help us understand if:
- There's any actual usage of MUI components in the code
- What other MUI packages are declared as dependencies
- Whether this project has any React dependencies that would justify MUI usage
Let me fix the regex and try one final verification:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any imports or usage of @mui/system
echo "Searching for @mui/system imports and usage..."
rg -l "@mui/system"
# Search for any Material-UI related imports
echo -e "\nSearching for other Material-UI related imports..."
rg -l "@mui/"
# Check package-lock.json for dependency relationships
echo -e "\nChecking if any other packages depend on @mui/system..."
if [ -f "package-lock.json" ]; then
jq '.packages | to_entries[] | select(.value.dependencies != null) | select(.value.dependencies["@mui/system"] != null) | .key' package-lock.json
fi
Length of output: 677
Script:
#!/bin/bash
# Check if there are any actual imports of @mui components in source files
echo "Checking for Material UI imports in source code..."
rg -l "from ['\"]\@mui/" --type ts --type js
# Check if @mui/lab and @mui/material are also in package.json
echo -e "\nChecking package.json for other MUI dependencies..."
jq '.dependencies | with_entries(select(.key | startswith("@mui/")))' package.json
# Look for any React-related dependencies to see if this is actually a frontend component
echo -e "\nChecking for React-related dependencies..."
jq '.dependencies | with_entries(select(.key | contains("react")))' package.json
Length of output: 671
Script:
#!/bin/bash
# Check for any MUI imports with fixed regex
echo "Checking for Material UI imports in source code..."
rg -l "from ['\"]@mui" --type ts --type js
# Check if this is actually a frontend project by looking for typical frontend files
echo -e "\nChecking for frontend-related files..."
fd -e jsx -e tsx
# Look for any React configuration files
echo -e "\nChecking for React configuration files..."
fd "react|vite|webpack" -t f
Length of output: 637
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make code rabbit approve the PR. It appears that this package is not being used in the code base.
Please fix the failing tests |
1efeb31
to
96d609b
Compare
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes #2540
Did you add tests for your changes?
No
Snapshots/Videos:
N/A
Summary
Updated the package @mui/system from 5.16.7 to 6.1.0
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes
Summary by CodeRabbit
This update improves the project's functionality by incorporating the latest version of the MUI system.