update pull-request.yml to ignore github actions when label "ignore-protected-files-pr" is added #2626
Conversation
…itHub action to be ignored label is added
WalkthroughThe changes in this pull request modify the GitHub Actions workflow in the Changes
Assessment against linked issues
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/pull-request.yml (1)
94-94: Consider documenting the label usage.
Since this introduces a new way to bypass protected file checks, consider adding documentation about:
- When to use this label
- Who can apply it
- Which files are considered protected
Add a comment above the condition explaining the bypass mechanism:
+ # Skip check for dependabot PRs and PRs with 'ignore-protected-files-pr' label
+ # This label should only be applied by maintainers for authorized changes to protected files
if: ${{ github.actor != 'dependabot[bot]' && !contains(github.event.pull_request.labels.*.name, 'ignore-protected-files-pr') }}Also, consider updating the repository's contributing guidelines to document this process.
🛑 Comments failed to post (0)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2626 +/- ##
========================================
Coverage 98.44% 98.44%
========================================
Files 342 342
Lines 16734 16734
Branches 2408 2408
========================================
Hits 16473 16473
Misses 258 258
Partials 3 3 ☔ View full report in Codecov by Sentry. |
varshith257
added
the
ignore-sensitive-files-pr
|
|
Please work with @varshith257 to figure out a solution |
|
@palisadoes I think this is done! |
|
@varshith257 Are you able to merge this? |
|
@palisadoes No
|
|
Please refresh the screen to verify |
|
@palisadoes |
|
Ask one of the other members to approve to check for sure. |
|
The develop branches require two approvals. |
|
@palisadoes Maybe due to the ruleset of the branch I can't see the merge option I guess |
|
@noman2002 We are just checking if the community members can merge PRS after all workflows passes and 2 approvals :) |
|
@varshith257 I think there was changes in unauthorised files and only admin can merge those PRs. May be that is why its not appearing. |
|
Yes, for that we have enabled skipping that step with the label |
|
@noman2002 It was because it requires two approvals for the |
|
@noman2002 I'm trying to see how we can delegate some of the PR approvals. |
|
I, @gautam-divyanshu and @AVtheking also tested it before where there were tests passed and 3 approvals were done and no unauthorized files were changed. I have seen similar behavior |
|
@varshith257 Are you saying that with 2 approvals from GitHub |
|
@palisadoes Yes (approvals are from me, @AVtheking and @gautam-divyanshu ) |
|
@varshith257 It needs to be approvals from formal GitHub members like you, @AVtheking, @gautam-divyanshu, @pranshugupta54 |
|
Please try again. |
|
Yes! wait let us simulate the same and will tag you |
|
I'll be sleeping. Please work with @noman2002 |
What kind of change does this PR introduce?
feature
Issue Number:
Fixes #2617
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
There are cases where community members need to edit sensitive files. When this is done, the Check-Sensitive-Files test fails. The formal GitHub contributors can only merge PRs where all tests pass. This means the Repository owners have to merge the PRs. This creates a bottleneck in PR reviews. updated pull-request.yml file for GitHub action to be ignored if this label is applied to the PR by any of our GitHub contributors
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
YEs
Summary by CodeRabbit