Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Feedback System #1387

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

EshaanAgg
Copy link
Contributor

What kind of change does this PR introduce?
This PR introduces the necessary models as well the resolvers need to implement a Feedback system in Talawa API.

Issue Number:
NA

Did you add tests for your changes?
Yes

Snapshots/Videos:
NA

If relevant, did you update the documentation?
NA

Summary
NA

Does this PR introduce a breaking change?
No

Other information
NA

Have you read the contributing guide?
Yes

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #1387 (be4aa6f) into develop (c0468a4) will increase coverage by 0.09%.
Report is 7 commits behind head on develop.
The diff coverage is 99.75%.

@@             Coverage Diff             @@
##           develop    #1387      +/-   ##
===========================================
+ Coverage    98.17%   98.27%   +0.09%     
===========================================
  Files          184      189       +5     
  Lines        10767    11472     +705     
  Branches       835      889      +54     
===========================================
+ Hits         10571    11274     +703     
- Misses         186      188       +2     
  Partials        10       10              
Files Changed Coverage Δ
src/resolvers/Mutation/leaveOrganization.ts 98.36% <93.75%> (-1.64%) ⬇️
src/resolvers/DirectChat/organization.ts 100.00% <100.00%> (ø)
src/resolvers/Event/attendees.ts 100.00% <100.00%> (ø)
src/resolvers/Event/averageFeedbackScore.ts 100.00% <100.00%> (ø)
src/resolvers/Event/feedback.ts 100.00% <100.00%> (ø)
src/resolvers/Feedback/event.ts 100.00% <100.00%> (ø)
src/resolvers/GroupChat/organization.ts 100.00% <100.00%> (ø)
src/resolvers/Mutation/acceptMembershipRequest.ts 100.00% <100.00%> (ø)
src/resolvers/Mutation/addFeedback.ts 100.00% <100.00%> (ø)
src/resolvers/Mutation/addOrganizationImage.ts 100.00% <100.00%> (ø)
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DMills27 DMills27 self-requested a review September 14, 2023 16:20
@EshaanAgg
Copy link
Contributor Author

@palisadoes Please merge.

@palisadoes palisadoes merged commit 07aed90 into PalisadoesFoundation:develop Sep 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants