-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ishtails #1380
Ishtails #1380
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
I have removed the commas from env, and changed name to Dev-Server from "Dev Server". I think that should fix the errors |
Codecov Report
@@ Coverage Diff @@
## develop #1380 +/- ##
===========================================
- Coverage 98.17% 98.17% -0.01%
===========================================
Files 184 184
Lines 10767 10770 +3
Branches 835 837 +2
===========================================
+ Hits 10571 10573 +2
- Misses 186 187 +1
Partials 10 10 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing due to inactivity |
What kind of change does this PR introduce?
PR CI/CD workflow feature
Issue Number:
Fixes #1343
Did you add tests for your changes?
No.
Snapshots/Videos:
N/A
If relevant, did you update the documentation?
No
Summary
Added a final github action to run the dev server using "npm run dev" before finishing checks as suggested by issue #1343
Does this PR introduce a breaking change?
No
Other information
Fixes the previous broken PR for fixing #1343
Have you read the contributing guide?
Yes