Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ishtails #1380

Closed
wants to merge 4 commits into from
Closed

Ishtails #1380

wants to merge 4 commits into from

Conversation

ishtails
Copy link
Contributor

What kind of change does this PR introduce?
PR CI/CD workflow feature

Issue Number:
Fixes #1343

Did you add tests for your changes?
No.

Snapshots/Videos:
N/A

If relevant, did you update the documentation?
No

Summary

Added a final github action to run the dev server using "npm run dev" before finishing checks as suggested by issue #1343

Does this PR introduce a breaking change?
No

Other information
Fixes the previous broken PR for fixing #1343

Have you read the contributing guide?
Yes

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@ishtails
Copy link
Contributor Author

I have removed the commas from env, and changed name to Dev-Server from "Dev Server". I think that should fix the errors

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1380 (24f4e21) into develop (c0468a4) will decrease coverage by 0.01%.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1380      +/-   ##
===========================================
- Coverage    98.17%   98.17%   -0.01%     
===========================================
  Files          184      184              
  Lines        10767    10770       +3     
  Branches       835      837       +2     
===========================================
+ Hits         10571    10573       +2     
- Misses         186      187       +1     
  Partials        10       10              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Sep 5, 2023
@palisadoes
Copy link
Contributor

Please scroll down this section and click on the links where the errors are occurring. They will explain what is going wrong.

image

@github-actions github-actions bot removed the no-pr-activity No pull request activity label Sep 7, 2023
@github-actions
Copy link

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Sep 17, 2023
@palisadoes
Copy link
Contributor

Closing due to inactivity

@palisadoes palisadoes closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No pull request activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/CD : Check for Starting a Server.
2 participants