-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override semver (to 7.5.4) in package.json #1372
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Please refer to the CONTRIBUTING.md file on how to auto-close issues when the PR is merged. This is important. |
I have edited my message to include " fixes #1360 " & also fixed the workflow error |
Codecov Report
@@ Coverage Diff @@
## develop #1372 +/- ##
========================================
Coverage 98.17% 98.17%
========================================
Files 184 184
Lines 10767 10767
Branches 835 835
========================================
Hits 10571 10571
Misses 186 186
Partials 10 10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I am a little unsure if manually updating the version of semver in all the dependent packages is how it should be done... let me know if there is a more standard way of doing this. For now, I have added a commit with manual version changes |
This is not correct. Please upgrade the dependencies rather than manually editing the dependency's dependencies. If there is no solution using this method, then let us know. |
1 similar comment
This is not correct. Please upgrade the dependencies rather than manually editing the dependency's dependencies. If there is no solution using this method, then let us know. |
I'm not sure how else to go about it... |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing due to inactivity |
What kind of change does this PR introduce?
bugfix
Issue Number:
fixes #1360
Did you add tests for your changes?
No
Snapshots/Videos:
NA
If relevant, did you update the documentation?
NA
Summary
Overrided semver in package.json to latest 7.5.4 version to fix semver vulnerable to Regular Expression Denial of Service as stated in #1360
Does this PR introduce a breaking change?
Not sure
Other information
NA
Have you read the contributing guide?
Yes