Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Create PR GitHub Actions logic for the ignore-protected-files-pr label #2617

Closed
palisadoes opened this issue Oct 27, 2024 · 5 comments
Closed
Assignees
Labels
feature request no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Oct 27, 2024

Is your feature request related to a problem? Please describe.

  1. The pull-request.yml workflow file has a section called Check-Sensitive-Files
  2. This GitHub action:
    1. was created to flag PRs that edited sensitive files that we want to protect from unauthorized changes
    2. is run on all PRs except those submitted by dependabot
  3. There are cases where community members need to edit sensitive files. When this is done, the Check-Sensitive-Files test fails. Our formal GitHub contributors can only merge PRs where all tests pass. This means the Repository owners have to merge the PRs. This creates a bottleneck in PR reviews

Describe the solution you'd like

  1. There is a ignore-sensitive-files-pr label in this repository
  2. We want only the Check-Sensitive-Files GitHub action to be ignored if this label is applied to the PR by any of our GitHub contributors
  3. No other functionality must be altered, especially the logic where the Check-Sensitive-Files GitHub action is also not run when the PR author is the dependabot user.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added test Testing application unapproved Unapproved for Pull Request labels Oct 27, 2024
@Sumitsh28
Copy link

I'd like to give this a try. Could you please assign it to me?

@palisadoes
Copy link
Contributor Author

I'd like to give this a try. Could you please assign it to me?

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@govindsingh3477
Copy link

can i work on this ?

@haresahani
Copy link

I’d like to work on this issue. Could you assign it to me?

Copy link

github-actions bot commented Nov 9, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 9, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-API (Tests) Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request no-issue-activity No issue activity test Testing application
Projects
Status: Done
Development

No branches or pull requests

5 participants