User Update email already exists error fix (#1385)

PalisadoesFoundation · Sep 20, 2023 · ef33a33 · ef33a33
1 parent 0312cf8
commit ef33a33
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/src/resolvers/Mutation/updateUserProfile.ts b/src/resolvers/Mutation/updateUserProfile.ts
@@ -33,12 +33,12 @@ export const updateUserProfile: MutationResolvers["updateUserProfile"] = async (
     );
   }
 
-  if (args.data?.email !== undefined) {
-    const userWithEmailExists = await User.find({
+  if (args.data?.email && args.data?.email !== currentUser?.email) {
+    const userWithEmailExists = await User.findOne({
       email: args.data?.email,
     });
 
-    if (userWithEmailExists.length > 0) {
+    if (userWithEmailExists) {
       throw new errors.ConflictError(
         requestContext.translate(EMAIL_ALREADY_EXISTS_ERROR.MESSAGE),
         EMAIL_ALREADY_EXISTS_ERROR.MESSAGE,

diff --git a/tests/resolvers/Mutation/updateUserProfile.spec.ts b/tests/resolvers/Mutation/updateUserProfile.spec.ts
@@ -188,6 +188,29 @@ describe("resolvers -> Mutation -> updateUserProfile", () => {
     }
   });
 
+  it(`updates if email not changed by user`, async () => {
+    const args: MutationUpdateUserProfileArgs = {
+      data: {
+        email: testUser.email,
+      },
+    };
+
+    const context = {
+      userId: testUser._id,
+    };
+
+    const updateUserProfilePayload = await updateUserProfileResolver?.(
+      {},
+      args,
+      context
+    );
+
+    expect(updateUserProfilePayload).toEqual({
+      ...testUser.toObject(),
+      image: null,
+    });
+  });
+
   it(`updates current user's user object when any single argument(email) is given w/0 changing other fields `, async () => {
     const args: MutationUpdateUserProfileArgs = {
       data: {