Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with Develop 2024-1-14 #2432

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

palisadoes
Copy link
Contributor

@palisadoes palisadoes commented Nov 14, 2024

Merge with Develop 2024-1-14

Summary by CodeRabbit

  • New Features

    • Introduced new components for managing event attendance, including AttendanceStatisticsModal and AddOnSpotAttendee.
    • Added a search and filter functionality for event attendees.
    • Implemented a leaderboard feature with localization support.
    • Enhanced the user interface with new CSS styles for various components.
  • Bug Fixes

    • Improved error handling and validation for form submissions in various components.
  • Documentation

    • Updated installation instructions and README for better clarity.
  • Tests

    • Expanded test coverage for multiple components, ensuring robust validation of functionality and error handling.
  • Style

    • Updated CSS styles for improved layout and visual consistency across components.

@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Nov 14, 2024
Copy link

coderabbitai bot commented Nov 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes multiple changes across various files, primarily focusing on configuration updates, new component additions, and enhancements to existing functionalities. Key modifications involve updating environment variables, refining ESLint rules, introducing new GraphQL mutations and queries, and enhancing test coverage for several components. Additionally, there are updates to CSS styles for improved UI presentation and the addition of localization strings in multiple languages to support new features related to event management and volunteer tracking.

Changes

File Path Change Summary
.env.example Updated REACT_APP_BACKEND_WEBSOCKET_URL to include a trailing slash; added newline at the end.
.eslintrc.json Removed @typescript-eslint/ban-types; added rules for type safety: no-unsafe-function-type, no-wrapper-object-types, no-empty-object-type.
.github/dependabot.yaml Changed schedule from weekly to monthly for dependency updates.
.github/workflows/auto-label.json5 New configuration added for label synonyms and default labels.
.github/workflows/codeql-codescan.yml Added condition to skip CodeQL analysis if triggered by dependabot[bot]; updated job name.
.github/workflows/eslint_disable_check.py Enhanced has_eslint_disable function for better error handling and regex detection.
.github/workflows/issue.yml Updated steps in Opened-issue-label job for handling issues, including new actions and updated parameters.
.github/workflows/pull-request.yml Renamed jobs and updated conditions to skip execution for dependabot[bot]; modified steps for better control flow.
.github/workflows/push.yml Added condition to skip Code-Coverage job for dependabot[bot]; updated job name.
.github/workflows/talawa_admin_md_mdx_format_adjuster.py New script introduced for processing Markdown files to MDX format.
.husky/pre-commit Uncommented npm run format:fix in pre-commit hook.
INSTALLATION.md Added section for REACT_APP_BACKEND_WEBSOCKET_URL setup; improved formatting and clarity.
README.md Adjusted formatting and minor content updates for clarity.
jest.config.js Reformatted transform section; added module mapping for @pdfme/generator.
package.json Updated multiple dependencies to their latest versions, including @mui, @pdfme/generator, and others.
public/locales/en/common.json Added new localization entries for session management.
public/locales/en/translation.json Introduced new sections for "leaderboard" and "eventVolunteers" with relevant keys.
public/locales/fr/common.json Added French translations for session management keys.
public/locales/fr/translation.json Expanded French translations for new features related to volunteer management.
public/locales/hi/common.json Added Hindi translations for session management keys.
public/locales/hi/translation.json Expanded Hindi translations for new features related to volunteer management.
public/locales/sp/common.json Added Spanish translations for session management keys.
public/locales/sp/translation.json Expanded Spanish translations for new features related to volunteer management.
public/locales/zh/common.json Added Chinese translations for session management keys.
public/locales/zh/translation.json Expanded Chinese translations for new features related to volunteer management.
schema.graphql Introduced new types for Community, Chat, and ChatMessage; updated mutations and queries for chat functionalities.
scripts/__mocks__/@dicebear/core.ts Updated mock implementation for createAvatar function.
scripts/__mocks__/@pdfme/generator.test.ts Added test suite for generate function with various test cases.
scripts/__mocks__/@pdfme/generator.ts Introduced a new asynchronous generate function for mock PDF generation.
setup.ts Enhanced environment variable handling and streamlined .env file updates.
src/App.tsx Added new routes for FundCampaignPledge and Leaderboard components; standardized route naming conventions.
src/GraphQl/Mutations/ActionItemMutations.ts Updated action item mutations to include new parameters and corrected names.
src/GraphQl/Mutations/EventVolunteerMutation.ts Introduced new mutations for managing event volunteers and groups.
src/GraphQl/Mutations/OrganizationMutations.ts Renamed and updated chat-related mutations and subscriptions.
src/GraphQl/Mutations/TagMutations.ts Added new mutations for managing user tags.
src/GraphQl/Queries/ActionItemQueries.ts Updated queries to include additional fields and corrected typos.
src/GraphQl/Queries/EventVolunteerQueries.ts Introduced new queries for event volunteers and groups.
src/GraphQl/Queries/OrganizationQueries.ts Removed fields from queries and added new parameters for user tags.
src/GraphQl/Queries/PlugInQueries.ts Removed direct chat queries and added new event-related queries.
src/GraphQl/Queries/Queries.ts Enhanced existing queries with new fields and added new queries for recurring events and community data.
src/GraphQl/Queries/userTagQueries.ts Updated existing queries to include new parameters and renamed fields.
src/components/AddOn/core/AddOnRegister/AddOnRegister.test.tsx Updated assertions for success notifications and added tests for redirection.
src/components/AddOn/core/AddOnRegister/AddOnRegister.tsx Renamed interface and updated default prop values.
src/components/AddPeopleToTag/AddPeopleToTag.module.css Introduced new styles for the AddPeopleToTag component.
src/components/AddPeopleToTag/AddPeopleToTag.test.tsx Established a new test suite covering various functionalities of the AddPeopleToTag component.
src/components/AddPeopleToTag/AddPeopleToTag.tsx Introduced a new component for managing user assignments to tags.
src/components/AddPeopleToTag/AddPeopleToTagsMocks.ts Added mock data for GraphQL queries related to user tags.
src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.test.tsx Updated assertions related to toast notifications and refined tests for advertisement creation.
src/components/AgendaCategory/AgendaCategoryContainer.test.tsx Updated assertions for toast notifications.
src/components/AgendaItems/AgendaItemsContainer.test.tsx Updated assertions for toast notifications related to agenda items.
src/components/Avatar/Avatar.module.css Modified styles for the avatar image container.
src/components/Avatar/Avatar.tsx Changed avatar generation method to asynchronous; improved error handling.
src/components/CheckIn/TableRow.test.tsx Introduced a new test case for PDF generation error handling.
src/components/CheckIn/TableRow.tsx Enhanced input validation and error handling in the generateTag function.
src/components/DynamicDropDown/DynamicDropDown.module.css Modified styles for dropdown toggle to occupy full width.
src/components/DynamicDropDown/DynamicDropDown.test.tsx Updated tests to improve specificity and added new test cases for user interactions.
src/components/DynamicDropDown/DynamicDropDown.tsx Enhanced type safety and added accessibility features to the dropdown component.
src/components/EventCalendar/EventCalendar.test.tsx Updated tests for consistent date handling and added checks for responsive behavior.
src/components/EventCalendar/EventCalendar.tsx Added data-testid attributes for better testing capabilities.
src/components/EventListCard/EventListCard.test.tsx Updated assertions for toast notifications and refined existing tests.
src/components/EventManagement/Dashboard/EventDashboard.mocks.ts Updated mock data for events with more detailed structures.
src/components/EventManagement/Dashboard/EventDashboard.module.css Modified styles for better layout and visual distinction.
src/components/EventManagement/Dashboard/EventDashboard.test.tsx Enhanced tests for specific element selection and added checks for loading states.
src/components/EventManagement/Dashboard/EventDashboard.tsx Updated rendering logic and state management for improved functionality.
src/components/EventManagement/EventAttendance/Attendance.mocks.ts Introduced mock data for event attendees.
src/components/EventManagement/EventAttendance/AttendedEventList.test.tsx Established a new test suite for the AttendedEventList component.
src/components/EventManagement/EventAttendance/AttendedEventList.tsx Introduced a component for displaying attended events.
src/components/EventManagement/EventAttendance/EventAttendance.test.tsx Comprehensive tests for the EventAttendance component covering various functionalities.
src/components/EventManagement/EventAttendance/EventAttendance.tsx New component for managing event attendance with filtering and sorting capabilities.
src/components/EventManagement/EventAttendance/EventStatistics.test.tsx New test suite for the AttendanceStatisticsModal component.
src/components/EventManagement/EventAttendance/EventStatistics.tsx New component for displaying attendance statistics with charting capabilities.
src/components/EventManagement/EventAttendance/EventsAttendance.module.css New CSS module for styling event attendance components.
src/components/EventManagement/EventAttendance/InterfaceEvents.ts Introduced new TypeScript interfaces for managing event attendance data.
src/components/EventRegistrantsModal/AddOnSpotAttendee.test.tsx Comprehensive test suite for the AddOnSpotAttendee component covering various functionalities.
src/components/EventRegistrantsModal/AddOnSpotAttendee.tsx New component for adding on-spot attendees to events.
src/components/EventRegistrantsModal/EventRegistrantsModal.test.tsx Updated test suite with enhanced mock data and new test cases for the EventRegistrantsModal.
src/components/EventRegistrantsModal/EventRegistrantsModal.tsx Modified to include functionality for on-the-spot registrations.
src/components/IconComponent/IconComponent.test.tsx Added test ID mapping for the new Volunteer icon.
src/components/IconComponent/IconComponent.tsx Introduced a new icon option for Volunteer.
src/components/InfiniteScrollLoader/InfiniteScrollLoader.module.css New CSS module for styling the infinite scroll loader component.

Possibly related PRs

Poem

🐰 In the fields where bunnies play,
New paths and routes have come our way.
With webs of code and hops of cheer,
We celebrate the changes here!
From tags to events, all in a row,
Let’s jump for joy, let our progress show! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes palisadoes merged commit d01b5d2 into PalisadoesFoundation:main Nov 14, 2024
7 of 10 checks passed
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 99.55291% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (e828b78) to head (d11e850).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/UserPortal/ChatRoom/ChatRoom.tsx 95.83% 2 Missing ⚠️
src/components/TagActions/TagActions.tsx 98.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2432      +/-   ##
==========================================
+ Coverage   97.54%   98.26%   +0.71%     
==========================================
  Files         242      297      +55     
  Lines        6888     8638    +1750     
  Branches     2015     2514     +499     
==========================================
+ Hits         6719     8488    +1769     
+ Misses        157      139      -18     
+ Partials       12       11       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes deleted the new-main branch November 14, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant