Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改COPY-FROM No.15 regularizer #5961

Conversation

Ainavo
Copy link
Contributor

@Ainavo Ainavo commented Jun 23, 2023

@paddle-bot
Copy link

paddle-bot bot commented Jun 23, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-5961.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

back = out.backward()
momentum.step()
momentum.clear_grad()
COPY-FROM: paddle.regularizer.L1Decay:code-example1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paddle 那边有加 name 吗?加完提一个 PR,并在本 PR 描述加上 PADDLEPADDLE_PR=<PR_ID>

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看代码是没有什么问题,但预览没有基于paddle pr构建,所以看不出是否正确

把pr 描述里的 PADDLEPADDLE_PR=<54926> 改成 PADDLEPADDLE_PR=54926,然后重新rerun试试

@Ainavo
Copy link
Contributor Author

Ainavo commented Jun 29, 2023

看代码是没有什么问题,但预览没有基于paddle pr构建,所以看不出是否正确

把pr 描述里的 PADDLEPADDLE_PR=<54926> 改成 PADDLEPADDLE_PR=54926,然后重新rerun试试

Done

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 299f4f5 into PaddlePaddle:develop Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants