You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request includes significant changes to the augmentation pipeline, dependencies, and testing framework. The main updates involve replacing imgaug with albumentations, introducing a custom resize transformation, and adding comprehensive tests for the new augmentation behavior.
Augmentation Pipeline Updates:
Replaced imgaug with albumentations for image augmentation, ensuring compatibility by preventing automatic updates in Albumentations (ppocr/data/imaug/iaa_augment.py).
Introduced ImgaugLikeResize, a custom resize transformation to mimic imgaug behavior with scaling (ppocr/data/imaug/iaa_augment.py).
Updated AugmenterBuilder to map common imgaug transformations to albumentations equivalents and handle custom augmenter arguments (ppocr/data/imaug/iaa_augment.py).
Dependency Updates:
Removed imgaug and added albumentations and albucore to the dependencies to support the new augmentation library (pyproject.toml). [1][2]
Testing Enhancements:
Added a new test file tests/test_iaa_augment.py with comprehensive tests for the new augmentation pipeline, including fixtures for sample images and polygons, and various test cases for different augmentation scenarios (tests/test_iaa_augment.py).
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 👍🏻 👍🏻
LGTM
BTW: we may need to remove library six after this PR landed, as we no longer need to support python2 any more.
there are several code snippets requiring six library, but should be easy to update.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GreatV
changed the title
This pull request includes significant changes to the augmentation pipeline, dependencies, and testing framework. The main updates involve replacing
imgaugwithalbumentations, introducing a custom resize transformation, and adding comprehensive tests for the new augmentation behavior.Augmentation Pipeline Updates:
imgaugwithalbumentationsfor image augmentation, ensuring compatibility by preventing automatic updates in Albumentations (ppocr/data/imaug/iaa_augment.py).ImgaugLikeResize, a custom resize transformation to mimicimgaugbehavior with scaling (ppocr/data/imaug/iaa_augment.py).AugmenterBuilderto map commonimgaugtransformations toalbumentationsequivalents and handle custom augmenter arguments (ppocr/data/imaug/iaa_augment.py).Dependency Updates:
imgaugand addedalbumentationsandalbucoreto the dependencies to support the new augmentation library (pyproject.toml). [1] [2]Testing Enhancements:
tests/test_iaa_augment.pywith comprehensive tests for the new augmentation pipeline, including fixtures for sample images and polygons, and various test cases for different augmentation scenarios (tests/test_iaa_augment.py).Training Log:
training log for ppocrv3
training log for ppocrv4
train_2.log
Related PR: