Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLU] add concurrentqueue.cmake #653

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Jun 28, 2023

PR描述:
Paddle 主框架在做第三方库离线编译,详情见 PaddlePaddle/Paddle#54305 。由于concurrentqueue这个第三方库Paddle实际上没有使用到,而目前对它有依赖的是PaddleCustomDevice中MLU后端,所以认为是寒武纪相关代码退场的遗留代码,Paddle主框架已经将其移除。

相关PR:
PaddlePaddle/Paddle#54438

Copy link
Collaborator

@KimBioInfoStudio KimBioInfoStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ShawnNew ShawnNew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShawnNew ShawnNew merged commit 7171b56 into PaddlePaddle:develop Jul 3, 2023
@ccsuzzh ccsuzzh deleted the add_concurrentqueue_cmake branch July 3, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants