math API support int tensor autocast to float32 易用性提升 #69252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Nov 12, 2024
| @@ -617,6 +663,15 @@ class {} : public egr::GradNodeBase {{ | |||
| }} | |||
| """ | |||
|
|
|||
| TYPE_AUTOCAST_LOGIC_TEMPLATE = """ | |||
There was a problem hiding this comment.
只有int情况下会被cast，还是所有情况下会被cast，不能引入不兼容的性能下降问题，只能对于之前不支持会报错的情况去cast
There was a problem hiding this comment.
只有在指定的op列表里且输入是int的时候会cast，应该不会不兼容。CE-Framework 的报错可能需要修改 PaddleTest 中的一些单测，因为有一些单测里面包含int输入会报错的case。
在 aistudio 上跑的结果
在 PaddleTest 中注释掉 paddle.sin 的单测：PaddlePaddle/PaddleTest#2992
zhwesky2010
reviewed
Nov 15, 2024
| @@ -388,11 +430,13 @@ def ceil(x: Tensor, name: str | None = None) -> Tensor: | |||
| out = \\left \\lceil x \\right \\rceil | |||
|
|
|||
| Args: | |||
| x (Tensor): Input of Ceil operator, an N-D Tensor, with data type float32, float64 or float16. | |||
| x (Tensor): Input of Ceil operator, an N-D Tensor, with data type float32, float64, float16, bfloat16, | |||
There was a problem hiding this comment.
有些上面check_dtype里写了complex64，下面文档里似乎没写，这个上下对齐一下吧
There was a problem hiding this comment.
好的，我再检查一下文档。 PaddleTest 我没有合入的权限，pr 是这个：PaddlePaddle/PaddleTest#2992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
以上支持整数类型输入自动提升为float32类型。
其中只有
paddle.ceil，paddle.floor也支持反向，梯度类型与输入类型一致。paddle.multigammaln，paddle.sinc由于是组合 API 实现，其中的 API 暂不支持 int 和 float 的类型提升，所以paddle.multigammaln，paddle.sinc暂不支持整数类型输入