-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dy2St] Use ShadowOutputOp
to get dy2st output
#60363
[Dy2St] Use ShadowOutputOp
to get dy2st output
#60363
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (var_name == orig_name) { | ||
return; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修改理由同 #59928 (comment)
ShadowOutputOp
for get dy2st outputShadowOutputOp
to get dy2st output
PR types
Bug fixes
PR changes
Others
Description
使用
ShadowOutputOp
替代SetParameterOp
获取输出结果,以避免执行器在SetParameterOp
为了确保 get 和 set 一致性而 trans 到 expected place 上,导致test_tensor_memcpy_on_cpu
明明x.cuda
却仍被 trans 回 CPU 的问题PCard-66972