Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] Use ShadowOutputOp to get dy2st output #60363

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Dec 26, 2023

PR types

Bug fixes

PR changes

Others

Description

使用 ShadowOutputOp 替代 SetParameterOp 获取输出结果,以避免执行器在 SetParameterOp 为了确保 get 和 set 一致性而 trans 到 expected place 上,导致 test_tensor_memcpy_on_cpu 明明 x.cuda 却仍被 trans 回 CPU 的问题

PCard-66972

Copy link

paddle-bot bot commented Dec 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +501 to +504
if (var_name == orig_name) {
return;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改理由同 #59928 (comment)

@SigureMo SigureMo changed the title [Dy2St] Use ShadowOutputOp for get dy2st output [Dy2St] Use ShadowOutputOp to get dy2st output Dec 28, 2023
@SigureMo SigureMo merged commit 875fbfb into PaddlePaddle:develop Dec 28, 2023
29 checks passed
@SigureMo SigureMo deleted the dy2st/use-shadow-output-for-dy2st-outputs branch December 28, 2023 07:15
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants