Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xdoctest] reformat example code with google style in No.386-389 #58206

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Oct 18, 2023

PR types

Others

PR changes

Others

Description

  • [xdoctest] 分批次修改已有代码的示例 #55629
    386-389
    flash_attention 里面2个函数
    1、flash_attn_unpadded error: "is_sm8x || is_sm75 check failed at /paddle/third_party/flashattn/csrc/flash_attn/flash_attn.cpp:293"
    2、scaled_dot_product_attention error: (InvalidArgument) flash_attn(): argument (position 5) must be double, but got NoneType (at ../paddle/fluid/pybind/op_function_common.cc:241)
    在cpu和gpu下还是报错

@paddle-bot
Copy link

paddle-bot bot commented Oct 18, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 18, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 18, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmmm,注意审题,我们只需要确保 SKIP 里面有 reason 即可,而且 reason 并不是报错,这样的 reason 是一点意义都没有的,有些改动甚至影响了本来的语义(如 python/paddle/quantization/factory.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要恢复

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,才发现

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以看一下原来的 commit hash,然后 cd 到这个 submodule 里,checkout 回原来的 commit hash

SigureMo
SigureMo previously approved these changes Oct 23, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

- out_vector(Tensor): A Tensor with shape [*, N, N] and data type of float32,float64,
complex64 and complex128. The eigenvectors of eigh op.
complex64 and complex128. The eigenvectors of eigh op.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

预览好像还是不行..两个段落之间空行试一下?@enkilee

@enkilee
Copy link
Contributor Author

enkilee commented Oct 25, 2023

@megemini 佬,有空PR审核下?

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@sunzhongkai588 sunzhongkai588 merged commit ff79525 into PaddlePaddle:develop Oct 25, 2023
28 checks passed
@enkilee enkilee deleted the xdoctest-386-389 branch November 8, 2023 01:24
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…dlePaddle#58206)

* fix

* undo mkldnn

* fix

* fix sys msg

* fix another sys msg

---------

Co-authored-by: SigureMo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants