Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] No.43 Migrate paddle.unsqueeze into pir #57617

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Sep 21, 2023

PR types

Others

PR changes

APIs

Description

[PIR]Migrate unsqueeze into pir
总计 24 个单测,打开12个单测,12个单测继承自unittest.TestCase没有覆盖到

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 21, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 22, 2023
@@ -36,10 +36,10 @@ def setUp(self):
self.outputs = {"Out": self.inputs["X"].reshape(self.new_shape)}

def test_check_output(self):
self.check_output()
self.check_output(check_new_ir=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参考其他单测文件,在setUp 函数中配置self.python_api = paddle.unsqueeze


def test_check_grad(self):
self.check_grad(["X"], "Out")
self.check_grad(["X"], "Out", check_new_ir=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可暂时关闭check_grad ,设置check_new_ir=False, 反向调用路径内部在修复

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsqueeze反向调用路径支持prhttps://github.com//pull/57681, 待此pr合入后可打开check_grad相关测试。 单测文件应该修改test_unsqueeze2_op.py

@longranger2
Copy link
Contributor Author

done

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoguoguo626807 xiaoguoguo626807 merged commit bd1584b into PaddlePaddle:develop Sep 26, 2023
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
* update unsqueeze in new ir

* fix bug

* Update test_unsqueeze2_op.py

* Update test_unsqueeze_op.py

* Update test_unsqueeze2_op.py
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
* update unsqueeze in new ir

* fix bug

* Update test_unsqueeze2_op.py

* Update test_unsqueeze_op.py

* Update test_unsqueeze2_op.py
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* update unsqueeze in new ir

* fix bug

* Update test_unsqueeze2_op.py

* Update test_unsqueeze_op.py

* Update test_unsqueeze2_op.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants