Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR] No.30 Migrate paddle.matmul into pir #57277

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Sep 13, 2023

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Sep 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 13, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 13, 2023
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要修改 test_matmul_v2_op单测, v1版本不再维护

@enkilee
Copy link
Contributor Author

enkilee commented Sep 14, 2023

需要修改 test_matmul_v2_op单测, v1版本不再维护

收到

@@ -463,6 +470,7 @@ def test_check_grad_y(self):
check_cinn=self.check_cinn
if hasattr(self, 'check_cinn')
else True,
check_new_ir=True,
)

def test_check_grad(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以修改一下TestMatMulV2API 单测,在510行之前加paddle.enable_static();528行之后加paddle.disable_static() 确保运行环境是静态图。新ir测试会影响部分单测环境

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants