-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xdoctest][task 331] reformat example code with google style in python/paddle/base/data_feeder.py #57138
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要根据 codestyle 流水线提示修复 codestyle 问题
2023-09-09 12:21:25 ************************************************************************************
2023-09-09 12:21:25 Your PR code style check failed.
2023-09-09 12:21:25 Please install pre-commit locally and set up git hook scripts:
2023-09-09 12:21:25
2023-09-09 12:21:25 pip install pre-commit==2.17.0
2023-09-09 12:21:25 pre-commit install
2023-09-09 12:21:25
2023-09-09 12:21:25 Then, run pre-commit to check codestyle issues in your PR:
2023-09-09 12:21:25
2023-09-09 12:21:25 pre-commit run --files python/paddle/base/data_feeder.py
2023-09-09 12:21:25
2023-09-09 12:21:25 For more information, please refer to our codestyle check guide:
2023-09-09 12:21:25 https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/codestyle_check_guide_cn.html
2023-09-09 12:21:25 ************************************************************************************
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python/paddle/base/data_feeder.py
Outdated
def reader(): | ||
for _ in range(4): | ||
yield np.random.random([4]).astype('float32'), np.random.random([3]).astype('float32'), | ||
>>> place = base.CPUPlace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尽可能不要用 base(原 fluid)
paddle.CPUPlace
paddle.static.Program
DataFeeder 不用改,没有对应的 API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问下“DataFeeder 不用改,没有对应的 API”是说这个文件不用改代码示例了吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请问下“DataFeeder 不用改,没有对应的 API”是说这个文件不用改代码示例了吗?
是说 base.DataFeeder
不用改成非 base API 而已,这个文件当然要改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMeow 🐾
…n/paddle/base/data_feeder.py (PaddlePaddle#57138) * [Doctest]fix No.331, test=docs_preview * enable static and clean fluid --------- Co-authored-by: SigureMo <[email protected]>
…n/paddle/base/data_feeder.py (PaddlePaddle#57138) * [Doctest]fix No.331, test=docs_preview * enable static and clean fluid --------- Co-authored-by: SigureMo <[email protected]>
PR types
Others
PR changes
Others
Description
修改如下文件的示例代码,使其通过
xdoctest
检查:python/paddle/base/data_feeder.py
预览:
Related links
@sunzhongkai588 @SigureMo @megemini