Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改COPY-FROM No.14 incubate #55234

Merged
merged 1 commit into from
Jul 19, 2023
Merged

修改COPY-FROM No.14 incubate #55234

merged 1 commit into from
Jul 19, 2023

Conversation

jjyaoao
Copy link
Contributor

@jjyaoao jjyaoao commented Jul 7, 2023 •
edited by luotao1
Loading

PR types

Others

PR changes

Docs

Description

更新 paddle.incubate 中部分类与接口的 docstring ，使支持新的中文文档生成方式。

@paddle-bot
Copy link

paddle-bot bot commented Jul 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 7, 2023
@jjyaoao jjyaoao mentioned this pull request Jul 7, 2023
Merged
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 7, 2023
@luotao1 luotao1 mentioned this pull request Jul 7, 2023
Closed
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 15, 2023

Sorry to inform you that ff363b4's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

sunzhongkai588
sunzhongkai588 previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs
@cxxly 该两个api中英文的代码示例之前是不一致的，为了保持一致，将中文的代码示例同步到英文，看看是否ok

@cxxly
Copy link
Contributor

cxxly commented Jul 18, 2023

解决CI报错

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Jul 18, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Jul 18, 2023
@luotao1
Copy link
Contributor

luotao1 commented Jul 18, 2023

后续修改文档的任务，可以在commit信息里加test=document_fix，来加速CI
https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/git_guides/paddle_ci_manual_cn.html#yigaishu
image

sunzhongkai588
sunzhongkai588 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cxxly
cxxly approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for bfgs/lbfgs

@luotao1 luotao1 merged commit cf14610 into PaddlePaddle:develop Jul 19, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
@jjyaoao @cqulilujia
修改COPY-FROM No.14 incubate (PaddlePaddle#55234)
c1e520b 
Signed-off-by: jjyaoao <[email protected]>
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@jjyaoao @wz1qqx
修改COPY-FROM No.14 incubate (PaddlePaddle#55234)
6264dab 
Signed-off-by: jjyaoao <[email protected]>
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@cxxly cxxly cxxly approved these changes

Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjyaoao @cxxly @luotao1 @sunzhongkai588