Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改COPY-FROM No.18 #54842

Merged
merged 16 commits into from
Jul 5, 2023
Merged

修改COPY-FROM No.18 #54842

merged 16 commits into from
Jul 5, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jun 25, 2023 •
edited
Loading

@paddle-bot
Copy link

paddle-bot bot commented Jun 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 25, 2023
@enkilee enkilee mentioned this pull request Jun 25, 2023
Closed
@SigureMo SigureMo self-requested a review June 25, 2023 06:24
SigureMo
SigureMo reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完成后先自查一下吧，在 docs 那边 PR 描述里加上 PADDLEPADDLE_PR=54842，这边不能使用 test=document_fix，因为 PADDLEPADDLE_PR=54842 依赖于这边编译好的 wheel 包，然后在 docs 那边的 preview 链接里确认所有代码都 COPY 成功后再找 review

python/paddle/fluid/framework.py Outdated Show resolved Hide resolved
python/paddle/fluid/framework.py Outdated Show resolved Hide resolved
@SigureMo
Copy link
Member

@megemini 有时间的话做一个任务作为示例 PR 吧，我上面说的几个关键点需要在任务描述里说明清楚，目前任务描述里的开发者引导是不太够的

@enkilee enkilee mentioned this pull request Jun 26, 2023
Merged
SigureMo
SigureMo reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs 侧需要在描述里加上 PADDLEPADDLE_PR=xxx

python/paddle/fluid/framework.py Outdated Show resolved Hide resolved
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 26, 2023
@enkilee enkilee changed the title 修改COPY-FROM No.18 test=document_fix 修改COPY-FROM No.18 Jun 27, 2023
sunzhongkai588
sunzhongkai588 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 567dabe into PaddlePaddle:develop Jul 5, 2023
@enkilee enkilee deleted the modify-copy-from branch July 6, 2023 01:28
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo left review comments

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enkilee @SigureMo @sunzhongkai588 @luotao1