add cudnn-frontend and dirent #54461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
risemeup1
reviewed
Jun 13, 2023
| endif() | ||
| endfunction() | ||
|
|
||
| download_dirent() | ||
|
|
There was a problem hiding this comment.
如果之前下载了到源码目录了，再重新执行，会再次下载吗？还是会覆盖掉？是否需要判断一下再决定下不下载呢？
risemeup1
reviewed
Jun 13, 2023
risemeup1
reviewed
Jun 16, 2023
FanSun126
reviewed
Sep 21, 2023
| set(DIRENT_URL | ||
| "https://github.com/tronkko/dirent/archive/refs/tags/1.23.2.tar.gz" | ||
| CACHE STRING "" FORCE) | ||
| set(DIRENT_CACHE_FILENAME "1.23.2.tar.gz") |
There was a problem hiding this comment.
win10下面使用cmake-gui编译时会因为DIRENT_CACHE_FILENAME这个变量没有设置而无法下载dirent然后报错，建议将set(DIRENT_CACHE_FILENAME "1.23.2.tar.gz")放到endif()后面，这样才能保证DIRENT_CACHE_FILENAME这个变量始终可以正确设置。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
#54305