support offline compilation for third-party snappy, cub and cutlass #54335
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
正在修复 ... |
|
Paddle/cmake/external/cub.cmake Lines 27 to 34 in 68d81d0
@risemeup1，我看任务说明里 cub 的 tag 和原始代码里的 tag 有区别，并且 cub repository 好像没有 1.18.0 的 tag，帮忙看下要怎么处理 |
直接以.cmake文件里的为准，任务说明里是之前统计的，可能更新了，也可能是我写错了。 |
| if(${CMAKE_CUDA_COMPILER_VERSION} GREATER_EQUAL 11.6) | ||
| # cuda_11.6/11.7/11.8‘s own cub is 1.15.0, which will cause compiling error in windows. | ||
| set(CUB_TAG 1.16.0) | ||
| execute_process(COMMAND git --git-dir=${CUB_SOURCE_DIR}/.git | ||
| --work-tree=${CUB_SOURCE_DIR} checkout ${CUB_TAG}) | ||
| # cub 1.16.0 is not compitable with current thrust version | ||
| add_definitions(-DTHRUST_IGNORE_CUB_VERSION_CHECK) | ||
| else() | ||
| set(CUB_TAG 1.8.0) | ||
| endif() |
There was a problem hiding this comment.
PR 里提交的 commit 是 1.8.0 分支，所以默认下载的是 1.8.0，然后如果需要 1.16.0 分支的话会执行命令切换
There was a problem hiding this comment.
PR 里提交的 commit 是 1.8.0 分支，所以默认下载的是 1.8.0，然后如果需要 1.16.0 分支的话会执行命令切换
| # cub 1.16.0 is not compitable with current thrust version | ||
| add_definitions(-DTHRUST_IGNORE_CUB_VERSION_CHECK) | ||
| else() | ||
| set(CUB_TAG 1.8.0) | ||
| endif() | ||
|
|
||
| set(CUB_INCLUDE_DIR ${CUB_PREFIX_DIR}/src/extern_cub) |
There was a problem hiding this comment.
这个地方是否有问题？源码目录下应该没有src/extern_cub目录
There was a problem hiding this comment.
已修改，因为原来的代码 git clone 的目录是 third_party/cub/src/extern_cub，这里直接把 CUB_INCLUDE_DIR 改为
${CUB_SOURCE_DIR} 就好了
|
@risemeup1，帮忙 Review 一下 |
PR types
Others
PR changes
Others
Description